Skip to content

Add C# management namespace and emitter output directory rules to required rules#44472

Open
skywing918 wants to merge 2 commits into
mainfrom
kyle/csharpMgmtToRequired
Open

Add C# management namespace and emitter output directory rules to required rules#44472
skywing918 wants to merge 2 commits into
mainfrom
kyle/csharpMgmtToRequired

Conversation

@skywing918

Copy link
Copy Markdown
Contributor

This pull request updates the validation rules in sdk-tspconfig-validation.ts to ensure that certain C# management configuration rules are now enforced as required rather than optional. This change helps enforce stricter validation for C# management TypeSpec configurations.

Validation rule updates:

  • Added TspConfigCsharpMgmtNamespaceSubRule and TspConfigCsharpMgmtEmitterOutputDirSubRule to the requiredRules list, making these checks mandatory for C# management configurations.
  • Removed TspConfigCsharpMgmtNamespaceSubRule and TspConfigCsharpMgmtEmitterOutputDirSubRule from the optionalRules list, reflecting their new status as required rules.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ The required check named TypeSpec Validation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide


Comment generated by summarize-checks workflow run.

@lirenhe

lirenhe commented Jul 7, 2026

Copy link
Copy Markdown
Member

Please hold the PR merge after .NET team updates all the existing tspconfig files to add the missing c# config for mgmt. plane. cc @live1206

@live1206 live1206 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please hold this until Azure/azure-sdk-for-net#60703 is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants