Add C# management namespace and emitter output directory rules to required rules#44472
Open
skywing918 wants to merge 2 commits into
Open
Add C# management namespace and emitter output directory rules to required rules#44472skywing918 wants to merge 2 commits into
skywing918 wants to merge 2 commits into
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
Member
|
Please hold the PR merge after .NET team updates all the existing tspconfig files to add the missing c# config for mgmt. plane. cc @live1206 |
live1206
requested changes
Jul 7, 2026
live1206
left a comment
Member
There was a problem hiding this comment.
please hold this until Azure/azure-sdk-for-net#60703 is done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the validation rules in
sdk-tspconfig-validation.tsto ensure that certain C# management configuration rules are now enforced as required rather than optional. This change helps enforce stricter validation for C# management TypeSpec configurations.Validation rule updates:
TspConfigCsharpMgmtNamespaceSubRuleandTspConfigCsharpMgmtEmitterOutputDirSubRuleto therequiredRuleslist, making these checks mandatory for C# management configurations.TspConfigCsharpMgmtNamespaceSubRuleandTspConfigCsharpMgmtEmitterOutputDirSubRulefrom theoptionalRuleslist, reflecting their new status as required rules.