Update update #6336
Closed
Update update #6336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gearama
requested review from
LarryOsterman,
antkmsft and
ahsonkhan
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
ahsonkhan
reviewed
Jan 13, 2025
sdk/tables/azure-data-tables/inc/azure/data/tables/table_client.hpp
Outdated
Show resolved
Hide resolved
ahsonkhan
reviewed
Jan 13, 2025
Comment on lines
+241
to
+242
| auto updateResponse | ||
| = m_tableClient->UpdateEntity(entity, Azure::Data::Tables::Models::UpdateMode::Update); |
There was a problem hiding this comment.
Do the tests here validate the difference between Update and Merge, based on the observable behavioral difference on the returned response or model?
E.g. if I change Update to Merge here, will the test fail or continue to pass?
It would be a good idea to add some assert to check the enum is honored as expected.
ahsonkhan
reviewed
Jan 13, 2025
…t.hpp Co-authored-by: Ahson Khan <[email protected]>
ahsonkhan
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Seems reasonable to align with other languages.
I would recommend having @LarryOsterman to review/approve before merging given the offline discussion.
|
reopening so i don't lose it till we come to a conclusion |
antkmsft
approved these changes
Jan 15, 2025
ahsonkhan
reviewed
Jan 17, 2025
ahsonkhan
reviewed
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6329
Based on the others languages mplementations the update and merge methods are being combined, upsertKind becomes updatemode, and the update method takes a new param
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.