Add support for building with ICU 75.1 or later #6486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
requested review from
gearama,
LarryOsterman,
antkmsft,
vinjiang,
Jinming-Hu,
EmmaZhu and
microzchang
as code owners
github-actions
bot
added
Community Contribution
|
Thank you for your contribution @kou! We will review the pull request and get back to you soon. |
kou
force-pushed
the
icu-c++17
branch
2 times, most recently
from
ed985d6 to
e4bb9fb
Compare
antkmsft
approved these changes
Mar 27, 2025
There was a problem hiding this comment.
Thank you, @kou! Looks great to me. Let's, just in case, hear from the code owners - @gearama and @microzchang / @Jinming-Hu .
We use ICU via libxml2 implicitly. ICU 75.1 or later require C++17 for its C++ API: https://github.com/unicode-org/icu/releases/tag/release-75-1 > C++ code now requires C++17 But we use C++17. So `#include <libxml/xmlreader.h>` with ICU 75.1 or later causes an error: [1/177] Building CXX object sdk/storage/azure-storage-common/CMakeFiles/azure-storage-common.dir/src/xml_wrapper.cpp.o FAILED: sdk/storage/azure-storage-common/CMakeFiles/azure-storage-common.dir/src/xml_wrapper.cpp.o /bin/c++ -DAZ_RTTI -DBUILD_CURL_HTTP_TRANSPORT_ADAPTER -D_azure_BUILDING_SDK -Isdk/storage/azure-storage-common/inc -Isdk/core/azure-core/inc -isystem /usr/include/libxml2 -g -std=gnu++14 -fno-operator-names -Wold-style-cast -Wall -Wextra -pedantic -Werror -MD -MT sdk/storage/azure-storage-common/CMakeFiles/azure-storage-common.dir/src/xml_wrapper.cpp.o -MF sdk/storage/azure-storage-common/CMakeFiles/azure-storage-common.dir/src/xml_wrapper.cpp.o.d -o sdk/storage/azure-storage-common/CMakeFiles/azure-storage-common.dir/src/xml_wrapper.cpp.o -c sdk/storage/azure-storage-common/src/xml_wrapper.cpp In file included from /usr/include/unicode/uenum.h:25, from /usr/include/unicode/ucnv.h:52, from /usr/include/libxml2/libxml/encoding.h:31, from /usr/include/libxml2/libxml/parser.h:812, from /usr/include/libxml2/libxml/globals.h:18, from /usr/include/libxml2/libxml/threads.h:35, from /usr/include/libxml2/libxml/xmlmemory.h:218, from /usr/include/libxml2/libxml/tree.h:1307, from /usr/include/libxml2/libxml/xmlreader.h:14, from sdk/storage/azure-storage-common/src/xml_wrapper.cpp:23: /usr/include/unicode/localpointer.h:561:26: error: 'auto' parameter not permitted in this context 561 | template <typename Type, auto closeFunction> | ^~~~ /usr/include/unicode/localpointer.h:573:76: error: template argument 2 is invalid 573 | explicit LocalOpenPointer(std::unique_ptr<Type, decltype(closeFunction)> &&p) | ^ /usr/include/unicode/localpointer.h:583:78: error: template argument 2 is invalid 583 | LocalOpenPointer &operator=(std::unique_ptr<Type, decltype(closeFunction)> &&p) { | ^ /usr/include/unicode/localpointer.h:599:59: error: template argument 2 is invalid 599 | operator std::unique_ptr<Type, decltype(closeFunction)> () && { | ^ /usr/include/unicode/uenum.h:69:1: note: invalid template non-type parameter 69 | U_DEFINE_LOCAL_OPEN_POINTER(LocalUEnumerationPointer, UEnumeration, uenum_close); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/unicode/ucnv.h:597:1: note: invalid template non-type parameter 597 | U_DEFINE_LOCAL_OPEN_POINTER(LocalUConverterPointer, UConverter, ucnv_close); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ We don't need ICU C++ API. So we can avoid this error by disabling ICU C++ API by defining `U_SHOW_CPLUSPLUS_API` as `0`.
|
API change check API changes are not detected in this pull request. |
antkmsft
reviewed
Mar 28, 2025
Co-authored-by: Anton Kolesnyk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.
We use ICU via libxml2 implicitly. ICU 75.1 or later require C++17 for its C++ API:
https://github.com/unicode-org/icu/releases/tag/release-75-1
But we use C++17. So
#include <libxml/xmlreader.h>with ICU 75.1 or later causes an error:We don't need ICU C++ API. So we can avoid this error by disabling ICU C++ API by defining
U_SHOW_CPLUSPLUS_APIas0.