Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPM braces and other package vulnerabilities #6487

Merged
merged 3 commits into from
Mar 28, 2025

Conversation

charlesfu001
Copy link

Pull Request Checklist

Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:

See the detailed list in the contributing guide.

  • C++ Guidelines
  • Doxygen docs
  • Unit tests
  • No unwanted commits/changes
  • Descriptive title/description
    • PR is single purpose
    • Related issue listed
  • Comments in source
  • No typos
  • Update changelog
  • Not work-in-progress
  • External references or docs updated
  • Self review of PR done
  • Any breaking changes?

@charlesfu001
Copy link
Author

@charlesfu001 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

@weshaggard
Copy link
Member

@charlesfu001 why are you trying to update this lock file? It is in our common code and would need to be updated in our azure-sdk-tools repo.

@charlesfu001
Copy link
Author

charlesfu001 commented Mar 27, 2025

@charlesfu001 why are you trying to update this lock file? It is in our common code and would need to be updated in our azure-sdk-tools repo.
@weshaggard, we don't plan to merge this change into main. A short history, our speech SDK is based on the feature branch feature/websockets, which Larry helped to develope the websocket work. This feature banch has not been merged back to main and we don't plan to merge it back to main. Does this clarify your question? Thanks.

BTW, we created a new feature branch feature/websockets_speech from the commit which we have been based on at feature/websockets. This change is applied to this new feature branch.

@weshaggard
Copy link
Member

OK so this is just a merge from main to update this. In which case that should be fine.

@charlesfu001
Copy link
Author

@weshaggard , @danieljurek , @benbp , I am not familiar with the process. Does this PR need to be approved by the repo owner to merge it into the feature branch or can it be approved by anyone with write permission, such as Ryan? If it needs to be approved by the repo owner, could you please approve the PR or if you have concerns, just let me know. Thanks.

@charlesfu001 charlesfu001 merged commit f36e749 into feature/websocket_speech Mar 28, 2025
17 of 35 checks passed
@charlesfu001 charlesfu001 deleted the changfu/fixbracesversion branch March 28, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants