-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keys update #6491
base: main
Are you sure you want to change the base?
Keys update #6491
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
The PR introduces configuration updates for the Key Vault Keys SDK, specifically adding new configuration files for the Typespec-based code generation process.
- Adds tspconfig.yaml which defines parameters, emitters, linter extensions, and options for code generation.
- Adds tsp-location.yaml that specifies the repository and location details for the API specifications.
Reviewed Changes
Copilot reviewed 13 out of 30 changed files in this pull request and generated no comments.
File | Description |
---|---|
sdk/keyvault/azure-security-keyvault-keys/tspconfig.yaml | Introduces configuration options for Typespec-based generation |
sdk/keyvault/azure-security-keyvault-keys/tsp-location.yaml | Specifies location details for API specification retrieval |
Files not reviewed (17)
- sdk/keyvault/assets.json: Language not supported
- sdk/keyvault/azure-security-keyvault-keys/CMakeLists.txt: Language not supported
- sdk/keyvault/azure-security-keyvault-keys/inc/azure/keyvault/keys/key_client.hpp: Language not supported
- sdk/keyvault/azure-security-keyvault-keys/inc/azure/keyvault/keys/key_client_models.hpp: Language not supported
- sdk/keyvault/azure-security-keyvault-keys/inc/azure/keyvault/keys/key_client_options.hpp: Language not supported
- sdk/keyvault/azure-security-keyvault-keys/src/key_client.cpp: Language not supported
- sdk/keyvault/azure-security-keyvault-keys/src/key_client_options.cpp: Language not supported
- sdk/keyvault/azure-security-keyvault-keys/src/key_client_paged_responses.cpp: Language not supported
- sdk/keyvault/azure-security-keyvault-keys/test/ut/CMakeLists.txt: Language not supported
- sdk/keyvault/azure-security-keyvault-keys/test/ut/key_client_create_test_live.cpp: Language not supported
- sdk/keyvault/azure-security-keyvault-keys/test/ut/key_client_test.cpp: Language not supported
- sdk/keyvault/azure-security-keyvault-keys/test/ut/key_cryptographic_client_test_live.cpp: Language not supported
- sdk/keyvault/azure-security-keyvault-keys/test/ut/mocked_client_test.cpp: Language not supported
- sdk/keyvault/azure-security-keyvault-keys/test/ut/mocked_transport_adapter_test.hpp: Language not supported
- sdk/keyvault/azure-security-keyvault-secrets/CMakeLists.txt: Language not supported
- sdk/keyvault/azure-security-keyvault-secrets/inc/azure/keyvault/secrets/secret_client.hpp: Language not supported
- sdk/keyvault/azure-security-keyvault-secrets/src/secret_serializers.cpp: Language not supported
API change check API changes are not detected in this pull request. |
sdk/keyvault/azure-security-keyvault-keys/inc/azure/keyvault/keys/key_client_models.hpp
Show resolved
Hide resolved
sdk/keyvault/azure-security-keyvault-keys/inc/azure/keyvault/keys/key_client_options.hpp
Outdated
Show resolved
Hide resolved
sdk/keyvault/azure-security-keyvault-keys/inc/azure/keyvault/keys/key_client_options.hpp
Show resolved
Hide resolved
sdk/keyvault/azure-security-keyvault-secrets/inc/azure/keyvault/secrets/secret_client.hpp
Show resolved
Hide resolved
@@ -156,7 +156,6 @@ namespace Azure { namespace Data { namespace Test { | |||
EXPECT_EQ(response.Value.Logging.Delete, false); | |||
EXPECT_EQ(response.Value.HourMetrics.RetentionPolicyDefinition.IsEnabled, true); | |||
EXPECT_EQ(response.Value.HourMetrics.Version, "1.0"); | |||
EXPECT_EQ(response.Value.HourMetrics.IsEnabled, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's weird unrelated change but had to do it because something changed in the infra and this property now is disabled in live. and i didn't want to make a new branch for one line change(VS gets really upset with me, need to do some cleanup on my machine).
I'm actively working on getting access to the TME subscription(where storage resources are deployed) to debug this.
This causes the live tests to fail for tables, and have been failing for a while. until i can get this debugged, since i couldn't deploy the resource i also couldn't record the tests again, thus ...
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.