[Release] sdk/resourcemanager/weightsandbiases/armweightsandbiases/1.0.0 #24576
+42
−146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0.0 generation from spec commit: 4a748a953cb8408283e3b5e9fd8773e012ca74ae
jliusan
requested review from
ArcturusZhang,
lirenhe,
tadelesh and
JiaqiZhang-Dev
as code owners
github-actions
bot
added
the
Mgmt
There was a problem hiding this comment.
Pull Request Overview
This PR updates the API versions from preview to 2024-09-18, updates example definition references, and bumps the module version to v1.0.0 as part of the release.
- Updated commit hash in tsp-location.yaml
- Converted all API version strings, example definition comments, and query parameters from "2024-09-18-preview" to "2024-09-18"
- Removed the fake time_rfc3339.go file and refined regex group count validations in the fake instances_server
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdk/resourcemanager/weightsandbiases/armweightsandbiases/tsp-location.yaml | Updated commit hash for the resource specification. |
| sdk/resourcemanager/weightsandbiases/armweightsandbiases/operations_client_example_test.go | Updated example definition references to the stable API version. |
| sdk/resourcemanager/weightsandbiases/armweightsandbiases/operations_client.go | Updated API version in comments and request parameters. |
| sdk/resourcemanager/weightsandbiases/armweightsandbiases/models.go | Reordered/updated comments for PartnerProperties field. |
| sdk/resourcemanager/weightsandbiases/armweightsandbiases/instances_client_example_test.go | Updated example definition references to the stable API version. |
| sdk/resourcemanager/weightsandbiases/armweightsandbiases/instances_client.go | Updated API version in comments and request parameters throughout the client methods. |
| sdk/resourcemanager/weightsandbiases/armweightsandbiases/fake/time_rfc3339.go | Removed; cleanup of unused fake implementation. |
| sdk/resourcemanager/weightsandbiases/armweightsandbiases/fake/instances_server.go | Updated regex validation conditions to ensure all expected URL groups are captured. |
| sdk/resourcemanager/weightsandbiases/armweightsandbiases/constants.go | Bumped module version to v1.0.0. |
| sdk/resourcemanager/weightsandbiases/armweightsandbiases/CHANGELOG.md | Added release notes for 1.0.0. |
Comments suppressed due to low confidence (1)
sdk/resourcemanager/weightsandbiases/armweightsandbiases/fake/time_rfc3339.go:1
- The removal of the fake/time_rfc3339.go file appears to be cleanup. Please confirm that no tests or dependencies rely on this file to avoid potential disruptions.
package fake
sdk/resourcemanager/weightsandbiases/armweightsandbiases/fake/instances_server.go
Show resolved
Hide resolved
|
please help fix the ci failures |
|
API change check API changes are not detected in this pull request. |
JiaqiZhang-Dev
approved these changes
May 15, 2025
sdk/resourcemanager/weightsandbiases/armweightsandbiases/CHANGELOG.md
Outdated
Show resolved
Hide resolved
…ELOG.md Co-authored-by: JiaqiZhang-Dev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/Azure/sdk-release-request/issues/6144