Skip to content

[Release] sdk/resourcemanager/chaos/armchaos/2.0.0 #24602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

azure-sdk
Copy link
Collaborator

…ec commit: cb79e798e4d8f10c9cc2c9fe8a99e306a445d714
@Copilot Copilot AI review requested due to automatic review settings May 9, 2025 01:08
@azure-sdk azure-sdk requested a review from ArcturusZhang as a code owner May 9, 2025 01:08
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Azure Chaos Resource Manager SDK to version 2.0.0 and shifts from the 2024-01-01 API to the 2025-01-01 API. Key changes include removal of legacy Go build tags, renaming of several parameters (e.g. using "location" instead of "locationName"), and updates to type definitions and enums (e.g. removal of ResourceIdentityType and addition of ExperimentActionType and ManagedServiceIdentityType).

Reviewed Changes

Copilot reviewed 43 out of 43 changed files in this pull request and generated 1 comment.

File Description
fake/*.go Removed Go build tags and updated function signatures/parameter names (e.g. asyncOperationID to operationID) to match API changes.
experiments_client.go Updated API version references, renamed parameters ("locationName" to "location"), and adjusted request payload marshalling to use the new type names.
capabilitytypes_client.go Adjusted parameter names and URL paths; updated API version and error messages.
autorest.md, README.md, CHANGELOG.md Updated module version, API version references, installation instructions, and changelog documentation.
Comments suppressed due to low confidence (1)

sdk/resourcemanager/chaos/armchaos/capabilitytypes_client.go:80

  • Ensure that the new 'location' parameter is consistently referenced in error messages and URL replacements, replacing all instances of the legacy 'locationName' to avoid confusion.
if location == "" { return nil, errors.New("parameter location cannot be empty") }

@@ -1,5 +1,38 @@
# Release History

## 2.0.0 (2025-05-23)
Copy link
Preview

Copilot AI May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the changelog clearly documents all breaking changes—including the removal of ResourceIdentityType and associated structures, as well as the renaming of several parameters—for the benefit of API consumers.

Copilot uses AI. Check for mistakes.

@azure-sdk
Copy link
Collaborator Author

azure-sdk commented May 9, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

sdk/resourcemanager/chaos/armchaos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants