-
Notifications
You must be signed in to change notification settings - Fork 906
[Release] sdk/resourcemanager/kubernetesconfiguration/armextensions/0.1.0 #24623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release] sdk/resourcemanager/kubernetesconfiguration/armextensions/0.1.0 #24623
Conversation
….1.0 generation from spec commit: ba0c086df0ebe03a61579485c1c10de0d17804b2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Initial release of the armextensions
package (v0.1.0) for Azure KubernetesConfiguration extensions.
- Generates client code (including
OperationStatusClient
), model types, options, and response wrappers. - Introduces a custom
dateTimeRFC3339
helper for robust JSON/text time parsing. - Adds fake server implementations, CI pipeline, module configuration, and documentation/examples.
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
sdk/resourcemanager/kubernetesconfiguration/armextensions/time_rfc3339.go | Add custom dateTimeRFC3339 parsing and marshalling |
sdk/resourcemanager/kubernetesconfiguration/armextensions/responses.go | Define response wrapper types |
sdk/resourcemanager/kubernetesconfiguration/armextensions/options.go | Define client options structs |
sdk/resourcemanager/kubernetesconfiguration/armextensions/operationstatus_client_example_test.go | Add example test for OperationStatusClient.Get |
sdk/resourcemanager/kubernetesconfiguration/armextensions/operationstatus_client.go | Implement OperationStatusClient GET method and request builder |
sdk/resourcemanager/kubernetesconfiguration/armextensions/models.go | Generate model types for Extension and related resources |
sdk/resourcemanager/kubernetesconfiguration/armextensions/go.mod | Initialize Go module and dependencies |
sdk/resourcemanager/kubernetesconfiguration/armextensions/fake/server_factory.go | Provide fake server transport factory |
sdk/resourcemanager/kubernetesconfiguration/armextensions/fake/operationstatus_server.go | Implement fake OperationStatusServer for testing |
sdk/resourcemanager/kubernetesconfiguration/armextensions/fake/internal.go | Internal helpers for fake servers |
sdk/resourcemanager/kubernetesconfiguration/armextensions/constants.go | Define module constants and enum types |
sdk/resourcemanager/kubernetesconfiguration/armextensions/client_factory.go | Add ClientFactory and client constructors |
sdk/resourcemanager/kubernetesconfiguration/armextensions/ci.yml | CI pipeline configuration |
sdk/resourcemanager/kubernetesconfiguration/armextensions/build.go | Integrate go generate build script |
sdk/resourcemanager/kubernetesconfiguration/armextensions/autorest.md | AutoRest generator configuration |
sdk/resourcemanager/kubernetesconfiguration/armextensions/README.md | Module documentation and examples |
sdk/resourcemanager/kubernetesconfiguration/armextensions/LICENSE.txt | MIT license |
sdk/resourcemanager/kubernetesconfiguration/armextensions/CHANGELOG.md | Release history for v0.1.0 |
Comments suppressed due to low confidence (2)
sdk/resourcemanager/kubernetesconfiguration/armextensions/operationstatus_client.go:78
- [nitpick] The function name getCreateRequest is misleading since it builds a GET request; consider renaming it to createGetRequest or getRequest for clarity.
func (client *OperationStatusClient) getCreateRequest(ctx context.Context, resourceGroupName string, clusterRp string, clusterResourceName string, clusterName string, extensionName string, operationID string, _ *OperationStatusClientGetOptions) (*policy.Request, error) {
sdk/resourcemanager/kubernetesconfiguration/armextensions/time_rfc3339.go:43
- There are no existing tests covering UnmarshalJSON for dateTimeRFC3339; consider adding unit tests for each format path (with/without 'T' and timezone offset) to ensure correct parsing.
func (t *dateTimeRFC3339) UnmarshalJSON(data []byte) error {
sdk/resourcemanager/kubernetesconfiguration/armextensions/time_rfc3339.go
Show resolved
Hide resolved
sdk/resourcemanager/kubernetesconfiguration/armextensions/time_rfc3339.go
Show resolved
Hide resolved
sdk/resourcemanager/kubernetesconfiguration/armextensions/fake/server_factory.go
Show resolved
Hide resolved
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
/azp run prepare-pipelines |
Azure Pipelines successfully started running 1 pipeline(s). |
sdk/resourcemanager/kubernetesconfiguration/armextensions/README.md
Outdated
Show resolved
Hide resolved
sdk/resourcemanager/kubernetesconfiguration/armextensions/README.md
Outdated
Show resolved
Hide resolved
sdk/resourcemanager/kubernetesconfiguration/armextensions/README.md
Outdated
Show resolved
Hide resolved
sdk/resourcemanager/kubernetesconfiguration/armextensions/README.md
Outdated
Show resolved
Hide resolved
sdk/resourcemanager/kubernetesconfiguration/armextensions/README.md
Outdated
Show resolved
Hide resolved
…ME.md Co-authored-by: JiaqiZhang-Dev <[email protected]>
…ME.md Co-authored-by: JiaqiZhang-Dev <[email protected]>
…ME.md Co-authored-by: JiaqiZhang-Dev <[email protected]>
…ME.md Co-authored-by: JiaqiZhang-Dev <[email protected]>
…ME.md Co-authored-by: JiaqiZhang-Dev <[email protected]>
/azp run prepare-pipelines |
Azure Pipelines successfully started running 1 pipeline(s). |
https://github.com/Azure/sdk-release-request/issues/6164