Skip to content

[Release] sdk/resourcemanager/kubernetesconfiguration/armextensions/0.1.0 #24623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jliusan
Copy link
Member

@jliusan jliusan commented May 13, 2025

….1.0 generation from spec commit: ba0c086df0ebe03a61579485c1c10de0d17804b2
@Copilot Copilot AI review requested due to automatic review settings May 13, 2025 08:24
@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label May 13, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Initial release of the armextensions package (v0.1.0) for Azure KubernetesConfiguration extensions.

  • Generates client code (including OperationStatusClient), model types, options, and response wrappers.
  • Introduces a custom dateTimeRFC3339 helper for robust JSON/text time parsing.
  • Adds fake server implementations, CI pipeline, module configuration, and documentation/examples.

Reviewed Changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
sdk/resourcemanager/kubernetesconfiguration/armextensions/time_rfc3339.go Add custom dateTimeRFC3339 parsing and marshalling
sdk/resourcemanager/kubernetesconfiguration/armextensions/responses.go Define response wrapper types
sdk/resourcemanager/kubernetesconfiguration/armextensions/options.go Define client options structs
sdk/resourcemanager/kubernetesconfiguration/armextensions/operationstatus_client_example_test.go Add example test for OperationStatusClient.Get
sdk/resourcemanager/kubernetesconfiguration/armextensions/operationstatus_client.go Implement OperationStatusClient GET method and request builder
sdk/resourcemanager/kubernetesconfiguration/armextensions/models.go Generate model types for Extension and related resources
sdk/resourcemanager/kubernetesconfiguration/armextensions/go.mod Initialize Go module and dependencies
sdk/resourcemanager/kubernetesconfiguration/armextensions/fake/server_factory.go Provide fake server transport factory
sdk/resourcemanager/kubernetesconfiguration/armextensions/fake/operationstatus_server.go Implement fake OperationStatusServer for testing
sdk/resourcemanager/kubernetesconfiguration/armextensions/fake/internal.go Internal helpers for fake servers
sdk/resourcemanager/kubernetesconfiguration/armextensions/constants.go Define module constants and enum types
sdk/resourcemanager/kubernetesconfiguration/armextensions/client_factory.go Add ClientFactory and client constructors
sdk/resourcemanager/kubernetesconfiguration/armextensions/ci.yml CI pipeline configuration
sdk/resourcemanager/kubernetesconfiguration/armextensions/build.go Integrate go generate build script
sdk/resourcemanager/kubernetesconfiguration/armextensions/autorest.md AutoRest generator configuration
sdk/resourcemanager/kubernetesconfiguration/armextensions/README.md Module documentation and examples
sdk/resourcemanager/kubernetesconfiguration/armextensions/LICENSE.txt MIT license
sdk/resourcemanager/kubernetesconfiguration/armextensions/CHANGELOG.md Release history for v0.1.0
Comments suppressed due to low confidence (2)

sdk/resourcemanager/kubernetesconfiguration/armextensions/operationstatus_client.go:78

  • [nitpick] The function name getCreateRequest is misleading since it builds a GET request; consider renaming it to createGetRequest or getRequest for clarity.
func (client *OperationStatusClient) getCreateRequest(ctx context.Context, resourceGroupName string, clusterRp string, clusterResourceName string, clusterName string, extensionName string, operationID string, _ *OperationStatusClientGetOptions) (*policy.Request, error) {

sdk/resourcemanager/kubernetesconfiguration/armextensions/time_rfc3339.go:43

  • There are no existing tests covering UnmarshalJSON for dateTimeRFC3339; consider adding unit tests for each format path (with/without 'T' and timezone offset) to ensure correct parsing.
func (t *dateTimeRFC3339) UnmarshalJSON(data []byte) error {

Copy link

github-actions bot commented May 13, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

sdk/resourcemanager/kubernetesconfiguration/armextensions

@jliusan
Copy link
Member Author

jliusan commented May 13, 2025

/azp run prepare-pipelines

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jliusan jliusan enabled auto-merge (squash) May 23, 2025 05:21
@jliusan
Copy link
Member Author

jliusan commented May 23, 2025

/azp run prepare-pipelines

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jliusan jliusan merged commit 4c8a20c into main May 23, 2025
5 checks passed
@jliusan jliusan deleted the release-kubernetesconfiguration-armextensions-0.1.0-1747124566 branch May 23, 2025 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants