-
Notifications
You must be signed in to change notification settings - Fork 906
Force a large pullrequest build without actually triggering a storm #24630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR forces a large build by replacing the dynamic retrieval of changed files with a manually specified list of file paths. Key changes include:
- Replacing dynamic file detection with a static array of file paths.
- Adding and retaining commented-out code blocks for reference.
- Maintaining an empty changedServices array.
@@ -47,7 +47,66 @@ $ArtifactName = Join-Path $ArtifactPath "diff.json" | |||
$changedFiles = @() | |||
$changedServices = @() | |||
|
|||
$changedFiles = Get-ChangedFiles -DiffPath $TargetPath | |||
$changedFiles = @( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a static list of files may lead to future maintenance issues if file changes occur; consider adding a comment or mechanism to keep this list up-to-date.
Copilot uses AI. Check for mistakes.
# $changedFiles = @( | ||
# "eng/scripts/Invoke-MgmtTestgen.ps1", | ||
# "eng/scripts/MgmtTestLib.ps1", | ||
# "eng/scripts/build.ps1", | ||
# "eng/tools/generator/cmd/v2/common/cmdProcessor.go", | ||
# "eng/tools/generator/cmd/v2/common/fileProcessor.go", | ||
# "eng/tools/generator/cmd/v2/common/generation.go", | ||
# "sdk/resourcemanager/advisor/armadvisor/build.go", | ||
# "sdk/resourcemanager/agrifood/armagrifood/build.go", | ||
# "sdk/resourcemanager/alertsmanagement/armalertsmanagement/build.go", | ||
# "sdk/resourcemanager/applicationinsights/armapplicationinsights/build.go", | ||
# "sdk/resourcemanager/appplatform/armappplatform/build.go", | ||
# "sdk/resourcemanager/appservice/armappservice/build.go", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The large commented-out block of code might clutter the script; if it is no longer needed, consider removing it to improve clarity.
# $changedFiles = @( | |
# "eng/scripts/Invoke-MgmtTestgen.ps1", | |
# "eng/scripts/MgmtTestLib.ps1", | |
# "eng/scripts/build.ps1", | |
# "eng/tools/generator/cmd/v2/common/cmdProcessor.go", | |
# "eng/tools/generator/cmd/v2/common/fileProcessor.go", | |
# "eng/tools/generator/cmd/v2/common/generation.go", | |
# "sdk/resourcemanager/advisor/armadvisor/build.go", | |
# "sdk/resourcemanager/agrifood/armagrifood/build.go", | |
# "sdk/resourcemanager/alertsmanagement/armalertsmanagement/build.go", | |
# "sdk/resourcemanager/applicationinsights/armapplicationinsights/build.go", | |
# "sdk/resourcemanager/appplatform/armappplatform/build.go", | |
# "sdk/resourcemanager/appservice/armappservice/build.go", | |
# Removed large commented-out block for clarity. |
Copilot uses AI. Check for mistakes.
Before cut over I want a large one to go through. This is an eng/common chance and so will never successfully merge.