Force a large pullrequest build without actually triggering a storm #24630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scbedd
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR forces a large build by replacing the dynamic retrieval of changed files with a manually specified list of file paths. Key changes include:
- Replacing dynamic file detection with a static array of file paths.
- Adding and retaining commented-out code blocks for reference.
- Maintaining an empty changedServices array.
| @@ -47,7 +47,66 @@ $ArtifactName = Join-Path $ArtifactPath "diff.json" | |||
| $changedFiles = @() | |||
| $changedServices = @() | |||
|
|
|||
| $changedFiles = Get-ChangedFiles -DiffPath $TargetPath | |||
| $changedFiles = @( | |||
There was a problem hiding this comment.
Using a static list of files may lead to future maintenance issues if file changes occur; consider adding a comment or mechanism to keep this list up-to-date.
Copilot uses AI. Check for mistakes.
Comment on lines
+134
to
+146
| # $changedFiles = @( | ||
| # "eng/scripts/Invoke-MgmtTestgen.ps1", | ||
| # "eng/scripts/MgmtTestLib.ps1", | ||
| # "eng/scripts/build.ps1", | ||
| # "eng/tools/generator/cmd/v2/common/cmdProcessor.go", | ||
| # "eng/tools/generator/cmd/v2/common/fileProcessor.go", | ||
| # "eng/tools/generator/cmd/v2/common/generation.go", | ||
| # "sdk/resourcemanager/advisor/armadvisor/build.go", | ||
| # "sdk/resourcemanager/agrifood/armagrifood/build.go", | ||
| # "sdk/resourcemanager/alertsmanagement/armalertsmanagement/build.go", | ||
| # "sdk/resourcemanager/applicationinsights/armapplicationinsights/build.go", | ||
| # "sdk/resourcemanager/appplatform/armappplatform/build.go", | ||
| # "sdk/resourcemanager/appservice/armappservice/build.go", |
There was a problem hiding this comment.
The large commented-out block of code might clutter the script; if it is no longer needed, consider removing it to improve clarity.
Suggested change
| # $changedFiles = @( | |
| # "eng/scripts/Invoke-MgmtTestgen.ps1", | |
| # "eng/scripts/MgmtTestLib.ps1", | |
| # "eng/scripts/build.ps1", | |
| # "eng/tools/generator/cmd/v2/common/cmdProcessor.go", | |
| # "eng/tools/generator/cmd/v2/common/fileProcessor.go", | |
| # "eng/tools/generator/cmd/v2/common/generation.go", | |
| # "sdk/resourcemanager/advisor/armadvisor/build.go", | |
| # "sdk/resourcemanager/agrifood/armagrifood/build.go", | |
| # "sdk/resourcemanager/alertsmanagement/armalertsmanagement/build.go", | |
| # "sdk/resourcemanager/applicationinsights/armapplicationinsights/build.go", | |
| # "sdk/resourcemanager/appplatform/armappplatform/build.go", | |
| # "sdk/resourcemanager/appservice/armappservice/build.go", | |
| # Removed large commented-out block for clarity. |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before cut over I want a large one to go through. This is an eng/common chance and so will never successfully merge.