Skip to content

[Release] sdk/resourcemanager/servicefabricmanagedclusters/armservicefabricmanagedclusters/0.4.0 #24692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jliusan
Copy link
Member

@jliusan jliusan commented May 27, 2025

…fabricmanagedclusters/0.4.0 generation from spec commit: 4b57132e90ee9adb1627f27f49d9e960cdeabf37
@Copilot Copilot AI review requested due to automatic review settings May 27, 2025 07:51
@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label May 27, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This release updates the SDK for Service Fabric Managed Clusters from version 0.3.0 to 0.4.0 with numerous modifications including a switch from the AutoRest Code Generator to the Go Code Generator, a change in the API version to "2025-03-01-preview", updates to the changelog and documentation, and various breaking changes to types and function signatures. Key changes include:

  • Removal of deprecated build tags and updating generated comments.
  • Consolidation of API version strings throughout request creation and poller functions.
  • Multiple breaking changes in type definitions and function signatures as noted in the changelog.

Reviewed Changes

Copilot reviewed 62 out of 62 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
constants.go Updated constants and added several new enum types and values.
*_client.go (various) Updated API version strings in request creation and poller invocations; removal of the FinalStateVia option in poller options.
build.go Removed deprecated build tags.
CHANGELOG.md Expanded changelog to document breaking changes and feature additions.
*_example_test.go Updated sample usage examples to reflect the new API version and function signatures.
Comments suppressed due to low confidence (2)

sdk/resourcemanager/servicefabricmanagedclusters/armservicefabricmanagedclusters/applicationtypeversions_client.go:57

  • [nitpick] The 'FinalStateVia' option has been removed from the NewPoller call. Please ensure that this change is intentional per the new API requirements and document its rationale so that future maintainers are aware of the new poller behavior.
poller, err := runtime.NewPoller(resp, client.internal.Pipeline(), &runtime.NewPollerOptions[ApplicationTypeVersionsClientCreateOrUpdateResponse]{

sdk/resourcemanager/servicefabricmanagedclusters/armservicefabricmanagedclusters/build.go:1

  • [nitpick] The removal of deprecated build tags is a significant change for the build process. Consider adding an explanatory comment or updating the changelog to highlight this update for users who may rely on them.
// Removed deprecated build tags

Copy link

API Change Check

APIView identified API level changes in this PR and created the following API reviews

sdk/resourcemanager/servicefabricmanagedclusters/armservicefabricmanagedclusters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant