Skip to content

[WIP] FileSystem Client Create Directory Doesn't Set Properties/Encryption Context #24697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented May 28, 2025

  • Add EncryptionContext field to directory.CreateOptions struct in directory/models.go
  • Update the format() method to pass the encryption context value to the generated client
  • Add a test to verify the functionality of creating directory with encryption context
  • Add a test to verify the functionality of creating directory with encryption context through filesystem client
  • Test the changes to ensure they work correctly (unable to run tests directly)

The changes I've made:

  1. Added the EncryptionContext field to the directory.CreateOptions struct in directory/models.go
  2. Updated the format() method to pass this value to the generated client's options
  3. Added tests for both directory client and filesystem client to verify the changes

These changes ensure that when creating a directory, users can specify the encryption context, which brings parity with the path API as requested in the issue.

Fixes #24010.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileSystem Client Create Directory Doesn't Set Properties/Encryption Context
2 participants