[Release] sdk/resourcemanager/cloudhealth/armcloudhealth/0.1.0 #24720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion from spec commit: a00d7ddccc290d3d5dd49a12094a3bce48dc30e2
jliusan
requested review from
ArcturusZhang,
lirenhe,
tadelesh and
JiaqiZhang-Dev
as code owners
github-actions
bot
added
the
Mgmt
There was a problem hiding this comment.
Pull Request Overview
This PR introduces version 0.1.0 of the Azure Cloudhealth Go SDK, generating client code, fake server implementations, tests, documentation, and CI configuration.
- Generated ARM client types and methods for new Cloudhealth resources
- Added in-memory fake servers for unit testing (fake package)
- Included examples, README, CI pipeline, metadata, and CHANGELOG entries
Reviewed Changes
Copilot reviewed 40 out of 40 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| fake/server_factory.go | ServerFactoryTransport logic for routing fakes |
| fake/*_server.go | Fake server transports for each client |
| internal.go | Shared utilities and tracker implementation |
| *_client.go & *_client_example_test.go | ARM client implementations and usage examples |
| constants.go, client_factory.go, _metadata.json | Module metadata, constants, and factory setup |
| ci.yml | CI configuration for the new SDK |
| README.md & CHANGELOG.md | Documentation and release history |
Comments suppressed due to low confidence (1)
sdk/resourcemanager/cloudhealth/armcloudhealth/fake/server_factory.go:43
- There are no unit tests covering ServerFactoryTransport initialization and the Do dispatch logic. Consider adding tests for missing CtxAPINameKey, unsupported clients, and concurrent Transporter initialization.
func NewServerFactoryTransport(srv *ServerFactory) *ServerFactoryTransport {
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
JiaqiZhang-Dev
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/Azure/sdk-release-request/issues/6260