Skip to content

[Release] sdk/resourcemanager/computeschedule/armcomputeschedule/1.1.0 #24737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jliusan
Copy link
Member

@jliusan jliusan commented Jun 4, 2025

…0 generation from spec commit: 0bf123645e53f9006c15a962087c9073d7fd455f
@Copilot Copilot AI review requested due to automatic review settings June 4, 2025 05:08
@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Jun 4, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Compute Schedule SDK to API version 2025-05-01, removes old AutoRest headers, and adds new batch execute methods for virtual machines.

  • Bumped API version and module version to 2025-05-01 (including go.mod and constants).
  • Added VirtualMachinesExecuteCreate and VirtualMachinesExecuteDelete client methods plus their request/response types.
  • Updated time_rfc3339.go to skip empty text unmarshals and added Content-Type headers to JSON requests.

Reviewed Changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
time_rfc3339.go Handle empty UnmarshalText input and update header
scheduledactions_client.go New batch execute methods; bump API version; headers
models.go Added new request/response types
models_serde.go JSON marshal/unmarshal for new types
responses.go Response structs for new methods
options.go Option structs for new methods
operations_client.go Bumped API version
operations_client_example_test.go Updated example names and imports
constants.go Bumped moduleVersion and API enums
go.mod Bumped azcore dependency
_metadata.json New emitter and API version metadata
CHANGELOG.md Changelog entries for 1.1.0 release
Comments suppressed due to low confidence (4)

sdk/resourcemanager/computeschedule/armcomputeschedule/models.go:78

  • Rename field Correlationid to CorrelationID to follow Go’s convention of capitalizing acronyms and maintain consistency across the client library.
Correlationid *string

sdk/resourcemanager/computeschedule/armcomputeschedule/models.go:102

  • Rename field Correlationid to CorrelationID in ExecuteDeleteRequest for consistency with other request types and Go naming standards.
Correlationid *string

sdk/resourcemanager/computeschedule/armcomputeschedule/scheduledactions_client.go:117

  • Consider adding unit tests or an example for VirtualMachinesExecuteCreate to ensure the new method is covered and behaves as expected.
func (client *ScheduledActionsClient) VirtualMachinesExecuteCreate(ctx context.Context, locationparameter string, requestBody ExecuteCreateRequest, options *ScheduledActionsClientVirtualMachinesExecuteCreateOptions) (ScheduledActionsClientVirtualMachinesExecuteCreateResponse, error) {

sdk/resourcemanager/computeschedule/armcomputeschedule/operations_client_example_test.go:15

  • [nitpick] The generated example function name is very long and hard to read. Consider renaming it to a concise, descriptive name like ExampleOperationsClient_NewListPager.
func ExampleOperationsClient_NewListPager_operationsListMaximumSetGenGeneratedByMaximumSetRuleGeneratedByMaximumSetRuleGeneratedByMaximumSetRuleGeneratedByMaximumSetRule() {

Copy link

github-actions bot commented Jun 4, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

sdk/resourcemanager/computeschedule/armcomputeschedule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants