Skip to content

[Release] sdk/resourcemanager/oracledatabase/armoracledatabase/1.1.0 #24738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jliusan
Copy link
Member

@jliusan jliusan commented Jun 4, 2025

jliusan added 2 commits June 4, 2025 16:39
…generation from spec commit: 3c2966598b7966dcca302d07dd7d28b1d1d744f3
@Copilot Copilot AI review requested due to automatic review settings June 4, 2025 09:15
@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Jun 4, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the Oracle Database ARM SDK to version 2.0.0 by updating the API version, adding new enums and client methods, and refreshing example tests.

  • Bump module and API version to 2.0.0 / 2025-03-01 across clients
  • Introduce new enum types and the BeginChangeDisasterRecoveryConfiguration operation
  • Update example tests, add JSON Content-Type headers, and refresh module import path to /v2

Reviewed Changes

Copilot reviewed 86 out of 86 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
constants.go Bumped moduleVersion, added new enum types
dbnodes_client_example_test.go Rewrote examples for BeginAction, updated example logic
*.go (client implementation files) Updated API version annotations, added Content-Type headers, removed old build tags
client_factory.go Added factory methods for new Exa*/Flex/GI clients
_metadata.json Updated to "apiVersion": "2025-03-01", bumped emitter
README.md Updated module import path to /v2
CHANGELOG.md Added detailed 2.0.0 release entries
Comments suppressed due to low confidence (2)

sdk/resourcemanager/oracledatabase/armoracledatabase/autonomousdatabases_client.go:51

  • No example test was added for the new BeginChangeDisasterRecoveryConfiguration method. Consider adding a corresponding example in an *_example_test.go file to ensure adequate test coverage for this new API.
func (client *AutonomousDatabasesClient) BeginChangeDisasterRecoveryConfiguration(ctx context.Context, resourceGroupName string, autonomousdatabasename string, body DisasterRecoveryConfigurationDetails, options *AutonomousDatabasesClientBeginChangeDisasterRecoveryConfigurationOptions) (*runtime.Poller[AutonomousDatabasesClientChangeDisasterRecoveryConfigurationResponse], error) {

sdk/resourcemanager/oracledatabase/armoracledatabase/dbnodes_client_example_test.go:30

  • [nitpick] The error messages 'failed to finish the request' and 'failed to pull the result' use inconsistent phrasing. Consider unifying them (e.g., both 'failed to complete request') for clarity and consistency.
log.Fatalf("failed to finish the request: %v", err)

Copy link

github-actions bot commented Jun 4, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

sdk/resourcemanager/oracledatabase/armoracledatabase

@jliusan jliusan changed the title [Release] sdk/resourcemanager/oracledatabase/armoracledatabase/2.0.0 [Release] sdk/resourcemanager/oracledatabase/armoracledatabase/1.1.0 Jun 10, 2025
@jliusan jliusan closed this Jun 10, 2025
@jliusan jliusan reopened this Jun 10, 2025
@mihretkidane-OCI mihretkidane-OCI merged commit da39b57 into main Jun 12, 2025
11 checks passed
@mihretkidane-OCI mihretkidane-OCI deleted the release-oracledatabase-armoracledatabase-2.0.0-1749026372 branch June 12, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants