-
Notifications
You must be signed in to change notification settings - Fork 907
[Release] sdk/resourcemanager/appconfiguration/armappconfiguration/3.0.0 #24757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Release] sdk/resourcemanager/appconfiguration/armappconfiguration/3.0.0 #24757
Conversation
…0.0 generation from spec commit: 4a2bb0762eaad11e725516708483598e0c12cabb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR releases version 3.0.0 of the armappconfiguration package, updating API versions from 2024-05-01 to 2024-06-01 and making a breaking change in the CreateOrUpdate method of KeyValuesClient by moving the key value parameters out of the options parameter. In addition, dependency versions in go.mod and various example and fake server references have been updated to reflect the new major version.
Reviewed Changes
Copilot reviewed 37 out of 37 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
sdk/resourcemanager/appconfiguration/armappconfiguration/keyvalues_client.go | Updated CreateOrUpdate method signature and API version string. |
sdk/resourcemanager/appconfiguration/armappconfiguration/go.mod | Updated module name from v2 to v3 and bumped dependency versions. |
sdk/resourcemanager/appconfiguration/armappconfiguration/fake/*.go | Updated API version and package import references from v2 to v3. |
sdk/resourcemanager/appconfiguration/armappconfiguration/*_example_test.go | Updated example references from v2 to v3 and API version URLs. |
sdk/resourcemanager/appconfiguration/armappconfiguration/CHANGELOG.md | Added changelog entries for breaking changes and new features. |
sdk/resourcemanager/appconfiguration/armappconfiguration/README.md | Updated go get command to use the v3 module. |
sdk/resourcemanager/appconfiguration/armappconfiguration/autorest.md | Updated module version and tag for code generator. |
Comments suppressed due to low confidence (1)
sdk/resourcemanager/appconfiguration/armappconfiguration/keyvalues_client.go:54
- The new CreateOrUpdate signature introduces a keyValueParameters parameter separate from the options. Please update the method’s documentation and migration guides to clearly describe this breaking change.
func (client *KeyValuesClient) CreateOrUpdate(ctx context.Context, resourceGroupName string, configStoreName string, keyValueName string, keyValueParameters KeyValue, options *KeyValuesClientCreateOrUpdateOptions) (KeyValuesClientCreateOrUpdateResponse, error) {
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
The breaking changes are introduced and approved in this PR |
@JeffreyRichter , please approve this major version release by adding label of Approved Major Version, thanks. |
https://github.com/Azure/sdk-release-request/issues/6238