-
Notifications
You must be signed in to change notification settings - Fork 907
[azcertificate] add fakes support #24768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for fakes in the azcertificates package and updates dependency versions, telemetry tracking, and naming consistency. Key changes include updating commit IDs and dependency versions, introducing fake implementations (including a fake tracker and custom server), and refactoring client operations to use a consistent telemetry pattern and parameter naming.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
sdk/security/keyvault/azcertificates/tsp-location.yaml | Updated commit ID to reference the latest specification commit. |
sdk/security/keyvault/azcertificates/testdata/perf/go.mod | Upgraded dependency versions for improved compatibility and performance. |
sdk/security/keyvault/azcertificates/internal/transforms.go | Adjusted regexReplace calls (including adding a new one for fake/server.go) to support optional parameters. |
sdk/security/keyvault/azcertificates/go.mod | Upgraded dependency versions. |
sdk/security/keyvault/azcertificates/fake/internal.go | Added a fake tracker implementation and helper functions for fake responses. |
sdk/security/keyvault/azcertificates/fake/custom_server.go | Introduced custom server initialization for fake challenges. |
sdk/security/keyvault/azcertificates/client.go | Refactored telemetry and parameter naming (using a constant operationName and renaming issuerName to name). |
sdk/security/keyvault/azcertificates/_metadata.json | Bumped the emitterVersion. |
eng/config.json | Adjusted the coverage goal for the azcertificates module. |
Comments suppressed due to low confidence (2)
sdk/security/keyvault/azcertificates/internal/transforms.go:31
- [nitpick] Verify that the regex pattern and its replacement (
?$1?
) correctly capture and update the certificate version parameter as intended without affecting unintended strings.
regexReplace("fake/server.go", `(\(?P<certificate_version\>(.*?))\)`, `?$1?`)
sdk/security/keyvault/azcertificates/fake/custom_server.go:11
- Ensure that 'serverTransportInterceptor' is declared (or imported) in the package prior to its assignment to avoid compilation errors.
serverTransportInterceptor = &internal.FakeChallenge{}
Part of #23355