-
Notifications
You must be signed in to change notification settings - Fork 953
[azkeys] add fakes support #24770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[azkeys] add fakes support #24770
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds fakes support for the Key Vault Keys client, updates request transforms for optional versions, and bumps several module versions.
- Introduce a
fakepackage with server and tracker utilities. - Update regex-based transforms and client span instrumentation to handle optional
versionpath parameters. - Bump
azidentity, internal Key Vault packages, Go module dependencies, and emitter version.
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tsp-location.yaml | Updated commit hash for API spec |
| go.mod (perf testdata & root) | Bumped azidentity, internal KV modules, and x/* deps |
| internal/transforms.go | Adjusted regex transforms for optional version paths |
| fake/internal.go | Added tracker, error types, and helper functions |
| fake/custom_server.go | Initialized fake challenge interceptor |
| client.go | Added operationName to context and enhanced spans |
| _metadata.json | Bumped emitterVersion |
| testdata/perf go.mod (azcertificates) | Bumped azidentity and x/* dependencies |
Comments suppressed due to low confidence (2)
sdk/security/keyvault/azkeys/fake/internal.go:27
- There are no tests covering the new
contains,newTracker, andtrackermethods; consider adding unit tests to ensure correct behavior of the fake utilities.
func contains[T comparable](s []T, v T) bool {
|
/go - pullrequest |
Pull request was closed
Part of #23355