Skip to content

Conversation

@gracewilcox
Copy link
Member

Part of #23355

@gracewilcox gracewilcox added KeyVault Client This issue points to a problem in the data-plane of the library. labels Jun 10, 2025
@gracewilcox gracewilcox marked this pull request as ready for review June 11, 2025 00:04
Copilot AI review requested due to automatic review settings June 11, 2025 00:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds fakes support for the Key Vault Keys client, updates request transforms for optional versions, and bumps several module versions.

  • Introduce a fake package with server and tracker utilities.
  • Update regex-based transforms and client span instrumentation to handle optional version path parameters.
  • Bump azidentity, internal Key Vault packages, Go module dependencies, and emitter version.

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tsp-location.yaml Updated commit hash for API spec
go.mod (perf testdata & root) Bumped azidentity, internal KV modules, and x/* deps
internal/transforms.go Adjusted regex transforms for optional version paths
fake/internal.go Added tracker, error types, and helper functions
fake/custom_server.go Initialized fake challenge interceptor
client.go Added operationName to context and enhanced spans
_metadata.json Bumped emitterVersion
testdata/perf go.mod (azcertificates) Bumped azidentity and x/* dependencies
Comments suppressed due to low confidence (2)

sdk/security/keyvault/azkeys/fake/internal.go:27

  • There are no tests covering the new contains, newTracker, and tracker methods; consider adding unit tests to ensure correct behavior of the fake utilities.
func contains[T comparable](s []T, v T) bool {

@github-project-automation github-project-automation bot moved this from Untriaged to In Progress in Azure SDK for Key Vault Jun 12, 2025
@gracewilcox gracewilcox enabled auto-merge (squash) June 12, 2025 22:14
@gracewilcox
Copy link
Member Author

/go - pullrequest

auto-merge was automatically disabled June 12, 2025 23:27

Pull request was closed

@github-project-automation github-project-automation bot moved this from In Progress to Done in Azure SDK for Key Vault Jun 12, 2025
@gracewilcox gracewilcox reopened this Jun 12, 2025
@github-project-automation github-project-automation bot moved this from Done to Untriaged in Azure SDK for Key Vault Jun 12, 2025
@gracewilcox gracewilcox merged commit 276096f into Azure:main Jun 12, 2025
13 checks passed
@github-project-automation github-project-automation bot moved this from Untriaged to Done in Azure SDK for Key Vault Jun 12, 2025
@gracewilcox gracewilcox deleted the kv-fakes-keys branch June 12, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue points to a problem in the data-plane of the library. KeyVault

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants