Skip to content

Conversation

@azure-sdk
Copy link
Collaborator

…m spec commit: 260ed6a52537921f53a18ffaf4020e3b4d510367
Copilot AI review requested due to automatic review settings August 9, 2025 01:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request releases version 2.0.0 of the Azure Storage SDK for Go, updating it from API version 2024-01-01 to 2025-01-01 with breaking changes to the module path.

  • Module path updated to include v2 suffix for major version release
  • API version upgraded from 2024-01-01 to 2025-01-01
  • New features added including IPv6 endpoint support, dual-stack preferences, and enhanced authentication settings

Reviewed Changes

Copilot reviewed 85 out of 86 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
version.go Sets module version to v2.0.0
go.mod Updates module path to v2 and dependency versions
models.go Adds new data structures for IPv6, placement, and authentication features
models_serde.go Implements serialization for new model properties
Various client files Updates API version references to 2025-01-01
Example and test files Updates import paths to use v2 module
Comments suppressed due to low confidence (2)

sdk/resourcemanager/storage/armstorage/models_serde.go:8392

  • The hardcoded string "Days" should be replaced with a constant or variable with a meaningful name to avoid magic values in the code.
	populate(objectMap, "interval", t.Interval)

sdk/resourcemanager/storage/armstorage/models_serde.go:8435

  • The hardcoded string "Days" should be replaced with a constant or variable with a meaningful name to avoid magic values in the code.
	populate(objectMap, "interval", t.Interval)

@github-actions
Copy link

github-actions bot commented Aug 9, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

sdk/resourcemanager/storage/armstorage

@jliusan
Copy link
Member

jliusan commented Aug 13, 2025

The breaking changes are introduced and approved in this PR,@jhendrixMSFT Could you approve the major version release because of the breaking changes? They have been approved in this spec PR.

@jliusan
Copy link
Member

jliusan commented Sep 23, 2025

@microsoft-github-policy-service rerun

@jliusan jliusan enabled auto-merge (squash) September 23, 2025 02:36
@jliusan jliusan merged commit e878b9a into main Sep 23, 2025
11 checks passed
@jliusan jliusan deleted the release-storage-armstorage-2.0.0-1754701835 branch September 23, 2025 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants