[Release] sdk/resourcemanager/management/armservicegroups/0.1.0 #25998
Open
[Release] sdk/resourcemanager/management/armservicegroups/0.1.0 #25998
Conversation
…ation from spec commit: 9762f2dd848f6955a855f5dbe8c4df8f4d5dfd66
jliusan
requested review from
JiaqiZhang-Dev,
lirenhe and
tadelesh
as code owners
github-actions
bot
added
the
Mgmt
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the initial generated Go management-plane SDK module armservicegroups (v0.1.0) under sdk/resourcemanager/management/, aligning with the release request in https://github.com/Azure/sdk-release-request/issues/6808.
Changes:
- Introduces the new
armservicegroupsmodule with generated clients, models, options/responses, and RFC3339 time handling. - Adds examples, fakes, and CI/build/autorest configuration files for the module.
- Adds release artifacts for v0.1.0 (CHANGELOG, version constants, go.mod/go.sum, LICENSE, README).
Reviewed changes
Copilot reviewed 23 out of 24 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/resourcemanager/management/armservicegroups/version.go | Declares module name/version constants for SDK telemetry/user-agent. |
| sdk/resourcemanager/management/armservicegroups/time_rfc3339.go | Implements custom RFC3339 (and Azure-variant) time serialization helpers used by models. |
| sdk/resourcemanager/management/armservicegroups/responses.go | Adds typed response wrappers for generated client methods. |
| sdk/resourcemanager/management/armservicegroups/options.go | Adds per-operation options types (including resume tokens for LROs). |
| sdk/resourcemanager/management/armservicegroups/models_serde.go | Adds JSON marshal/unmarshal implementations for generated models. |
| sdk/resourcemanager/management/armservicegroups/models.go | Defines the public model types for the ServiceGroups API surface. |
| sdk/resourcemanager/management/armservicegroups/groupsrpapis_client_example_test.go | Adds generated usage examples for GroupsRPAPIsClient LRO operations. |
| sdk/resourcemanager/management/armservicegroups/groupsrpapis_client.go | Implements GroupsRPAPIsClient operations (create/update/delete) including LRO plumbing. |
| sdk/resourcemanager/management/armservicegroups/go.sum | Adds dependency checksums for the new module. |
| sdk/resourcemanager/management/armservicegroups/go.mod | Adds the module definition and dependencies (azcore/azidentity). |
| sdk/resourcemanager/management/armservicegroups/fake/server_factory.go | Adds fake server factory transport for unit testing clients without live service calls. |
| sdk/resourcemanager/management/armservicegroups/fake/server.go | Adds fake server/transport for Client methods (Get/ListAncestors). |
| sdk/resourcemanager/management/armservicegroups/fake/internal.go | Adds shared fake server helpers (non-retriable errors, trackers). |
| sdk/resourcemanager/management/armservicegroups/fake/groupsrpapis_server.go | Adds fake server/transport for GroupsRPAPIsClient LRO operations. |
| sdk/resourcemanager/management/armservicegroups/constants.go | Adds enum-like constants and “Possible*Values” helpers. |
| sdk/resourcemanager/management/armservicegroups/client_factory.go | Adds ClientFactory to create module clients sharing the same internal arm.Client. |
| sdk/resourcemanager/management/armservicegroups/client_example_test.go | Adds generated usage examples for Client methods. |
| sdk/resourcemanager/management/armservicegroups/client.go | Implements Client operations (Get/ListAncestors). |
| sdk/resourcemanager/management/armservicegroups/ci.yml | Adds Azure Pipelines configuration for CI on this module path. |
| sdk/resourcemanager/management/armservicegroups/build.go | Adds go:generate entrypoint to regenerate this SDK via repo scripts. |
| sdk/resourcemanager/management/armservicegroups/autorest.md | Adds AutoRest configuration used to generate the SDK. |
| sdk/resourcemanager/management/armservicegroups/README.md | Adds package README with setup and usage guidance. |
| sdk/resourcemanager/management/armservicegroups/LICENSE.txt | Adds MIT license file for the module. |
| sdk/resourcemanager/management/armservicegroups/CHANGELOG.md | Adds initial release notes for v0.1.0. |
| A client groups a set of related APIs, providing access to its functionality. Create one or more clients to access the APIs you require using client factory. | ||
|
|
||
| ```go | ||
| client := clientFactory.() |
There was a problem hiding this comment.
The README client creation snippet is invalid Go (clientFactory.()), so users can't copy/paste it. Replace it with a concrete factory call like clientFactory.NewClient() (and/or clientFactory.NewGroupsRPAPIsClient() depending on the API you want to demonstrate).
Suggested change
| client := clientFactory.() | |
| client, err := clientFactory.NewGroupsRPAPIsClient() |
| } | ||
| res, err := poller.PollUntilDone(ctx, nil) | ||
| if err != nil { | ||
| log.Fatalf("failed to pull the result: %v", err) |
There was a problem hiding this comment.
Typo in the example error message: it says "failed to pull the result" but this is a poller, so it should be "failed to poll the result".
Suggested change
| log.Fatalf("failed to pull the result: %v", err) | |
| log.Fatalf("failed to poll the result: %v", err) |
| } | ||
| res, err := poller.PollUntilDone(ctx, nil) | ||
| if err != nil { | ||
| log.Fatalf("failed to pull the result: %v", err) |
There was a problem hiding this comment.
Typo in the example error message: it says "failed to pull the result" but this is a poller, so it should be "failed to poll the result".
| } | ||
| _, err = poller.PollUntilDone(ctx, nil) | ||
| if err != nil { | ||
| log.Fatalf("failed to pull the result: %v", err) |
There was a problem hiding this comment.
Typo in the example error message: it says "failed to pull the result" but this is a poller, so it should be "failed to poll the result".
Member
Author
|
/azp run prepare-pipelines |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/check-enforcer evaluate |
Member
Author
|
/check-enforcer override |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/Azure/sdk-release-request/issues/6808