[Migrate-Check--Main-Branch] sdk/resourcemanager/hdinsight/armhdinsight #26003
Open
[Migrate-Check--Main-Branch] sdk/resourcemanager/hdinsight/armhdinsight #26003
Conversation
…eration from spec commit: 6312b1c8676b0973f86f078c1177dcb7510158df
jliusan
requested review from
JiaqiZhang-Dev,
lirenhe and
tadelesh
as code owners
github-actions
bot
added
the
Mgmt
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the sdk/resourcemanager/hdinsight/armhdinsight Go module by regenerating it from the package-2025-01-preview Swagger tag (newer azure-rest-api-specs commit), resulting in updated generated clients/models/examples and a module version bump.
Changes:
- Regenerated ARM HDInsight client code, models, and example tests from the updated Swagger/spec commit.
- Introduced new/updated model types (e.g., ARM-style error types) and added
SystemDatato base resource shapes/serde. - Bumped module version to
v1.3.0-beta.4and updated changelog/go module metadata.
Reviewed changes
Copilot reviewed 30 out of 32 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/resourcemanager/hdinsight/armhdinsight/virtualmachines_client_example_test.go | Regenerated example links/header updates. |
| sdk/resourcemanager/hdinsight/armhdinsight/virtualmachines_client.go | Doc comment updates (subscription/resource group descriptions). |
| sdk/resourcemanager/hdinsight/armhdinsight/version.go | Module version bump to v1.3.0-beta.4. |
| sdk/resourcemanager/hdinsight/armhdinsight/scriptexecutionhistory_client_example_test.go | Regenerated example links/header updates. |
| sdk/resourcemanager/hdinsight/armhdinsight/scriptexecutionhistory_client.go | Doc comment updates. |
| sdk/resourcemanager/hdinsight/armhdinsight/scriptactions_client_example_test.go | Example set/order updated; adds/removes specific examples per spec. |
| sdk/resourcemanager/hdinsight/armhdinsight/scriptactions_client.go | Doc comment updates. |
| sdk/resourcemanager/hdinsight/armhdinsight/responses.go | Response wrapper comment updates from regeneration. |
| sdk/resourcemanager/hdinsight/armhdinsight/privatelinkresources_client_example_test.go | Regenerated example links/header updates. |
| sdk/resourcemanager/hdinsight/armhdinsight/privatelinkresources_client.go | Doc comment updates. |
| sdk/resourcemanager/hdinsight/armhdinsight/privateendpointconnections_client_example_test.go | Example set/order updated; regenerated sample bodies. |
| sdk/resourcemanager/hdinsight/armhdinsight/privateendpointconnections_client.go | Doc comment updates. |
| sdk/resourcemanager/hdinsight/armhdinsight/operations_client_example_test.go | Regenerated example links/header updates. |
| sdk/resourcemanager/hdinsight/armhdinsight/operations_client.go | Doc comment update for options parameter. |
| sdk/resourcemanager/hdinsight/armhdinsight/models_serde.go | Serde changes: new error types, systemData serialization, removed serde for removed structs. |
| sdk/resourcemanager/hdinsight/armhdinsight/models.go | Model changes: new error structs, added SystemData to base resources, removed two structs, comment/field doc updates. |
| sdk/resourcemanager/hdinsight/armhdinsight/locations_client_example_test.go | Added/updated location-related examples per updated spec; regenerated output. |
| sdk/resourcemanager/hdinsight/armhdinsight/locations_client.go | Doc comment updates (location description, request body params). |
| sdk/resourcemanager/hdinsight/armhdinsight/go.sum | Dependency checksum updates from regeneration/tidy. |
| sdk/resourcemanager/hdinsight/armhdinsight/go.mod | Dependency version updates (notably azidentity change) and indirect bumps. |
| sdk/resourcemanager/hdinsight/armhdinsight/extensions_client_example_test.go | Example set/order updated; regenerated LRO vs GET examples. |
| sdk/resourcemanager/hdinsight/armhdinsight/extensions_client.go | Doc comment updates. |
| sdk/resourcemanager/hdinsight/armhdinsight/constants.go | Added per-constant doc comments from regeneration. |
| sdk/resourcemanager/hdinsight/armhdinsight/configurations_client_example_test.go | Example set/order updated; regenerated request/response comments. |
| sdk/resourcemanager/hdinsight/armhdinsight/configurations_client.go | Doc comment updates. |
| sdk/resourcemanager/hdinsight/armhdinsight/clusters_client.go | Doc comment updates across methods. |
| sdk/resourcemanager/hdinsight/armhdinsight/client_factory.go | Doc comment update for subscriptionID. |
| sdk/resourcemanager/hdinsight/armhdinsight/autorest.md | Updated require spec paths/commit, module-version bump, enabled lenient model deduplication. |
| sdk/resourcemanager/hdinsight/armhdinsight/applications_client_example_test.go | Regenerated example links/header updates. |
| sdk/resourcemanager/hdinsight/armhdinsight/applications_client.go | Doc comment updates. |
| sdk/resourcemanager/hdinsight/armhdinsight/CHANGELOG.md | Added 1.3.0-beta.4 entry noting breaking/model changes. |
|
|
||
| // ApplicationListResult - Result of the request to list cluster Applications. It contains a list of operations and a URL | ||
| // link to get the next set of results. | ||
| // ApplicationListResult - The response of a Application list operation. |
There was a problem hiding this comment.
Grammar: “The response of a Application list operation.” should be “an Application …” to read correctly in GoDoc.
Suggested change
| // ApplicationListResult - The response of a Application list operation. | |
| // ApplicationListResult - The response of an Application list operation. |
Comment on lines
5
to
+13
| require ( | ||
| github.com/Azure/azure-sdk-for-go/sdk/azcore v1.20.0 | ||
| github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.13.1 | ||
| github.com/Azure/azure-sdk-for-go/sdk/azcore v1.21.0 | ||
| github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.10.1 | ||
| ) | ||
|
|
||
| require ( | ||
| github.com/Azure/azure-sdk-for-go/sdk/internal v1.11.2 // indirect | ||
| github.com/AzureAD/microsoft-authentication-library-for-go v1.6.0 // indirect | ||
| github.com/golang-jwt/jwt/v5 v5.3.0 // indirect | ||
| github.com/AzureAD/microsoft-authentication-library-for-go v1.4.2 // indirect | ||
| github.com/golang-jwt/jwt/v5 v5.2.2 // indirect |
There was a problem hiding this comment.
go.mod downgrades github.com/Azure/azure-sdk-for-go/sdk/azidentity from v1.13.1 to v1.10.1 (and also downgrades MSAL/jwt indirect versions). This makes this module an outlier vs most sdk/resourcemanager/* modules and can reintroduce older bugs/security fixes. Prefer keeping azidentity aligned with the repo’s current baseline (e.g., v1.13.1) unless there’s a confirmed compatibility requirement, and re-run go get/go mod tidy to update sums accordingly.
| type ApplicationsClientListByClusterResponse struct { | ||
| // Result of the request to list cluster Applications. It contains a list of operations and a URL link to get the next set | ||
| // of results. | ||
| // The response of a Application list operation. |
There was a problem hiding this comment.
Grammar: “The response of a Application list operation.” should use “an” ("an application"). Please adjust to avoid awkward generated GoDoc.
Suggested change
| // The response of a Application list operation. | |
| // The response of an application list operation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on main branch from swagger tag:package-2025-01-preview