[Migrate-Check-Typespec-Mitigate] sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery#26018
[Migrate-Check-Typespec-Mitigate] sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery#26018
Conversation
| - Struct `ProtectableItemQueryParameter` has been removed | ||
| - Struct `ProtectedClustersQueryParameter` has been removed | ||
| - Struct `ProtectedItemsQueryParameter` has been removed | ||
|
|
There was a problem hiding this comment.
All breaking changes are new
| - Struct `ProtectedItemsQueryParameter` has been removed | ||
|
|
||
| ### Features Added | ||
|
|
There was a problem hiding this comment.
New Features Added:
- New enum type
CreatedByTypewith valuesCreatedByTypeApplication,CreatedByTypeKey,CreatedByTypeManagedIdentity,CreatedByTypeUser - New struct
SystemData - New field
SystemDatain structAlert - New field
SystemDatain structEvent - New field
SystemDatain structFabric - New field
SystemDatain structJob - New field
SystemDatain structLogicalNetwork - New field
SystemDatain structMigrationItem - New field
SystemDatain structMigrationRecoveryPoint - New field
SystemDatain structNetwork - New field
SystemDatain structNetworkMapping - New field
SystemDatain structPolicy - New field
SystemDatain structProtectableItem - New field
SystemDatain structProtectionContainer - New field
SystemDatain structProtectionContainerMapping - New field
SystemDatain structRecoveryPlan - New field
SystemDatain structRecoveryPoint - New field
SystemDatain structRecoveryServicesProvider - New field
SystemDatain structReplicationEligibilityResults - New field
SystemDatain structReplicationProtectedItem - New field
SystemDatain structReplicationProtectionCluster - New field
SystemDatain structReplicationProtectionIntent - New field
SystemDatain structStorageClassification - New field
SystemDatain structStorageClassificationMapping - New field
SystemDatain structSupportedOperatingSystems - New field
SystemDatain structVCenter - New field
SystemDatain structVaultHealthDetails - New field
SystemDatain structVaultSetting
API Change CheckAPIView identified API level changes in this PR and created the following API reviews sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery |
There was a problem hiding this comment.
Pull request overview
Migrates armrecoveryservicessiterecovery to the TypeSpec-based Go generator output, bumps the module to v3, and updates generated clients/fakes/examples to API version 2025-08-01.
Changes:
- Bumps module path to
/v3, addsversion.go, and updates dependencies. - Regenerates ARM clients, options/responses, and fake servers using the Go Code Generator (API version
2025-08-01). - Updates examples/testdata metadata and documents breaking changes in the changelog.
Reviewed changes
Copilot reviewed 86 out of 113 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/version.go | Adds generated module name/version constants for v3. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/tsp-location.yaml | Adds TypeSpec emitter provenance/config for regeneration. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/time_rfc3339.go | Removes legacy AutoRest RFC3339 time helper. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/testdata/_metadata.json | Adds testdata metadata for new API/emitter version. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/targetcomputesizes_client_example_test.go | Updates examples to v3 import and new response shapes. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/targetcomputesizes_client.go | Regenerated client with updated API version and request construction. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/supportedoperatingsystems_client_example_test.go | Updates examples to v3 import and simplified options usage. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/supportedoperatingsystems_client.go | Regenerated client with updated API version and request construction. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/responses.go | Adds new response type for ReinstallMobilityService LRO. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/replicationvaultsetting_client.go | Regenerated client; updates docs and API version; adds JSON content-type. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/replicationvaulthealth_client_example_test.go | Updates examples to v3 import and new response shapes. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/replicationvaulthealth_client.go | Regenerated client with updated API version and request construction. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/replicationstorageclassifications_client.go | Regenerated client with updated API version and improved docs. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/replicationprotectionintents_client.go | Regenerated client; updated API version; adds JSON content-type. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/replicationprotectableitems_client.go | Regenerated client with updated API version and pager docs. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/replicationnetworks_client.go | Regenerated client with updated API version and improved docs. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/replicationlogicalnetworks_client_example_test.go | Updates examples to v3 import; adds Get example and adjusts responses. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/replicationlogicalnetworks_client.go | Regenerated client with updated API version and improved docs. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/replicationevents_client.go | Regenerated client with updated API version and improved docs. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/replicationeligibilityresults_client.go | Regenerated client with updated API version and updated URL paths. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/replicationappliances_client_example_test.go | Updates examples to v3 import and response shapes. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/replicationappliances_client.go | Regenerated pager client with updated API version and docs. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/replicationalertsettings_client.go | Regenerated client; updated API version; adds JSON content-type. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/recoverypoints_client.go | Regenerated client with updated API version and improved docs. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/polymorphic_helpers.go | Updates generator header to Go Code Generator. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/options.go | Adds new options type for ReinstallMobilityService LRO. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/operations_client.go | Regenerated operations pager with updated API version and docs. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/migrationrecoverypoints_client.go | Regenerated client with updated API version and docs. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/interfaces.go | Updates generator header to Go Code Generator. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/go.sum | Updates dependency checksums (azcore, x/*). |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/go.mod | Bumps module path to v3 and updates dependency versions. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/targetcomputesizes_server.go | Updates fake server to v3 import and corrects path parsing checks. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/supportedoperatingsystems_server.go | Updates fake server to v3 import and path parsing checks. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/server_factory.go | Updates generator header to Go Code Generator. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationvcenters_server.go | Updates fake server to v3 import and path parsing checks. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationvaultsetting_server.go | Updates fake server to v3 import and path parsing checks. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationvaulthealth_server.go | Updates fake server to v3 import and path parsing checks. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationstorageclassifications_server.go | Updates fake server to v3 import and path parsing checks. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationstorageclassificationmappings_server.go | Updates fake server to v3 import and path parsing checks. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationrecoveryservicesproviders_server.go | Updates fake server to v3 import and path parsing checks. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationprotectionintents_server.go | Updates fake server to v3 import and path parsing checks. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationprotectioncontainers_server.go | Updates fake server to v3 import and path parsing checks. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationprotectioncontainermappings_server.go | Updates fake server to v3 import and path parsing checks. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationprotectableitems_server.go | Updates fake server to v3 import and path parsing checks. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationpolicies_server.go | Updates fake server to v3 import and path parsing checks. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationnetworks_server.go | Updates fake server to v3 import and path parsing checks. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationnetworkmappings_server.go | Updates fake server to v3 import and path parsing checks. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationlogicalnetworks_server.go | Updates fake server to v3 import and path parsing checks. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationjobs_server.go | Updates fake server to v3 import and path parsing checks. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationfabrics_server.go | Updates fake server to v3 import and path parsing checks. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationevents_server.go | Updates fake server to v3 import and path parsing checks. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationeligibilityresults_server.go | Updates fake server to v3 import and aligns regex path casing. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationappliances_server.go | Updates fake server to v3 import and path parsing checks. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationalertsettings_server.go | Updates fake server to v3 import and path parsing checks. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/recoverypoints_server.go | Updates fake server to v3 import and path parsing checks. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/operations_server.go | Updates fake server to v3 import and path parsing checks. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/migrationrecoverypoints_server.go | Updates fake server to v3 import and path parsing checks. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/internal.go | Updates generator header to Go Code Generator. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/clusterrecoverypoints_server.go | Updates fake server to v3 import and path parsing checks. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/clusterrecoverypoint_server.go | Updates fake server to v3 import and path parsing checks. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/clusterrecoverypoints_client_example_test.go | Updates examples to v3 import and new response shapes. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/clusterrecoverypoints_client.go | Regenerated pager client with updated API version and docs. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/clusterrecoverypoint_client_example_test.go | Updates examples to v3 import and new response shapes. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/clusterrecoverypoint_client.go | Regenerated client with updated API version and docs. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/client_factory.go | Updates generator header and subscriptionID doc for v3. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/build.go | Removes legacy go generate build hook (AutoRest-era). |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/autorest.md | Removes AutoRest configuration (replaced by TypeSpec metadata). |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/README.md | Updates install instructions to v3 module path. |
| sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/CHANGELOG.md | Adds v3.0.0 release notes with breaking changes/features. |
Comments suppressed due to low confidence (2)
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/replicationeligibilityresults_client.go:1
- The provider namespace segment is lowercased (
providers/microsoft.Compute) while other paths in this SDK use canonicalMicrosoft.*casing. Even if ARM routing is case-insensitive, keeping canonical casing improves consistency and avoids edge cases with intermediaries/proxies. Consider switching these toproviders/Microsoft.Compute(and align the fake server regex accordingly).
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/replicationeligibilityresults_client.go:1 - The provider namespace segment is lowercased (
providers/microsoft.Compute) while other paths in this SDK use canonicalMicrosoft.*casing. Even if ARM routing is case-insensitive, keeping canonical casing improves consistency and avoids edge cases with intermediaries/proxies. Consider switching these toproviders/Microsoft.Compute(and align the fake server regex accordingly).
| // NewClientFactory creates a new instance of ClientFactory with the specified values. | ||
| // The parameter values will be propagated to any client created from this factory. | ||
| // - subscriptionID - The subscription Id. | ||
| // - subscriptionID - The ID of the target subscription. The value must be an UUID. |
There was a problem hiding this comment.
Grammar: use 'a UUID' instead of 'an UUID' in doc comments.
| // - subscriptionID - The ID of the target subscription. The value must be an UUID. | |
| // - subscriptionID - The ID of the target subscription. The value must be a UUID. |
base on branch:ruih/recoveryservicessiterecovery-tsp-convert