Skip to content

Comments

[Migrate-Check-Typespec-Mitigate] sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery#26018

Open
jliusan wants to merge 1 commit intomainfrom
mitigate-recovertservice2
Open

[Migrate-Check-Typespec-Mitigate] sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery#26018
jliusan wants to merge 1 commit intomainfrom
mitigate-recovertservice2

Conversation

@jliusan
Copy link
Member

@jliusan jliusan commented Feb 12, 2026

base on branch:ruih/recoveryservicessiterecovery-tsp-convert

Copilot AI review requested due to automatic review settings February 12, 2026 06:16
@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Feb 12, 2026
- Struct `ProtectableItemQueryParameter` has been removed
- Struct `ProtectedClustersQueryParameter` has been removed
- Struct `ProtectedItemsQueryParameter` has been removed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All breaking changes are new

- Struct `ProtectedItemsQueryParameter` has been removed

### Features Added

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New Features Added:

  • New enum type CreatedByType with values CreatedByTypeApplication, CreatedByTypeKey, CreatedByTypeManagedIdentity, CreatedByTypeUser
  • New struct SystemData
  • New field SystemData in struct Alert
  • New field SystemData in struct Event
  • New field SystemData in struct Fabric
  • New field SystemData in struct Job
  • New field SystemData in struct LogicalNetwork
  • New field SystemData in struct MigrationItem
  • New field SystemData in struct MigrationRecoveryPoint
  • New field SystemData in struct Network
  • New field SystemData in struct NetworkMapping
  • New field SystemData in struct Policy
  • New field SystemData in struct ProtectableItem
  • New field SystemData in struct ProtectionContainer
  • New field SystemData in struct ProtectionContainerMapping
  • New field SystemData in struct RecoveryPlan
  • New field SystemData in struct RecoveryPoint
  • New field SystemData in struct RecoveryServicesProvider
  • New field SystemData in struct ReplicationEligibilityResults
  • New field SystemData in struct ReplicationProtectedItem
  • New field SystemData in struct ReplicationProtectionCluster
  • New field SystemData in struct ReplicationProtectionIntent
  • New field SystemData in struct StorageClassification
  • New field SystemData in struct StorageClassificationMapping
  • New field SystemData in struct SupportedOperatingSystems
  • New field SystemData in struct VCenter
  • New field SystemData in struct VaultHealthDetails
  • New field SystemData in struct VaultSetting

@github-actions
Copy link

API Change Check

APIView identified API level changes in this PR and created the following API reviews

sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrates armrecoveryservicessiterecovery to the TypeSpec-based Go generator output, bumps the module to v3, and updates generated clients/fakes/examples to API version 2025-08-01.

Changes:

  • Bumps module path to /v3, adds version.go, and updates dependencies.
  • Regenerates ARM clients, options/responses, and fake servers using the Go Code Generator (API version 2025-08-01).
  • Updates examples/testdata metadata and documents breaking changes in the changelog.

Reviewed changes

Copilot reviewed 86 out of 113 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/version.go Adds generated module name/version constants for v3.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/tsp-location.yaml Adds TypeSpec emitter provenance/config for regeneration.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/time_rfc3339.go Removes legacy AutoRest RFC3339 time helper.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/testdata/_metadata.json Adds testdata metadata for new API/emitter version.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/targetcomputesizes_client_example_test.go Updates examples to v3 import and new response shapes.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/targetcomputesizes_client.go Regenerated client with updated API version and request construction.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/supportedoperatingsystems_client_example_test.go Updates examples to v3 import and simplified options usage.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/supportedoperatingsystems_client.go Regenerated client with updated API version and request construction.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/responses.go Adds new response type for ReinstallMobilityService LRO.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/replicationvaultsetting_client.go Regenerated client; updates docs and API version; adds JSON content-type.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/replicationvaulthealth_client_example_test.go Updates examples to v3 import and new response shapes.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/replicationvaulthealth_client.go Regenerated client with updated API version and request construction.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/replicationstorageclassifications_client.go Regenerated client with updated API version and improved docs.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/replicationprotectionintents_client.go Regenerated client; updated API version; adds JSON content-type.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/replicationprotectableitems_client.go Regenerated client with updated API version and pager docs.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/replicationnetworks_client.go Regenerated client with updated API version and improved docs.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/replicationlogicalnetworks_client_example_test.go Updates examples to v3 import; adds Get example and adjusts responses.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/replicationlogicalnetworks_client.go Regenerated client with updated API version and improved docs.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/replicationevents_client.go Regenerated client with updated API version and improved docs.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/replicationeligibilityresults_client.go Regenerated client with updated API version and updated URL paths.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/replicationappliances_client_example_test.go Updates examples to v3 import and response shapes.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/replicationappliances_client.go Regenerated pager client with updated API version and docs.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/replicationalertsettings_client.go Regenerated client; updated API version; adds JSON content-type.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/recoverypoints_client.go Regenerated client with updated API version and improved docs.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/polymorphic_helpers.go Updates generator header to Go Code Generator.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/options.go Adds new options type for ReinstallMobilityService LRO.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/operations_client.go Regenerated operations pager with updated API version and docs.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/migrationrecoverypoints_client.go Regenerated client with updated API version and docs.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/interfaces.go Updates generator header to Go Code Generator.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/go.sum Updates dependency checksums (azcore, x/*).
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/go.mod Bumps module path to v3 and updates dependency versions.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/targetcomputesizes_server.go Updates fake server to v3 import and corrects path parsing checks.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/supportedoperatingsystems_server.go Updates fake server to v3 import and path parsing checks.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/server_factory.go Updates generator header to Go Code Generator.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationvcenters_server.go Updates fake server to v3 import and path parsing checks.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationvaultsetting_server.go Updates fake server to v3 import and path parsing checks.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationvaulthealth_server.go Updates fake server to v3 import and path parsing checks.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationstorageclassifications_server.go Updates fake server to v3 import and path parsing checks.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationstorageclassificationmappings_server.go Updates fake server to v3 import and path parsing checks.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationrecoveryservicesproviders_server.go Updates fake server to v3 import and path parsing checks.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationprotectionintents_server.go Updates fake server to v3 import and path parsing checks.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationprotectioncontainers_server.go Updates fake server to v3 import and path parsing checks.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationprotectioncontainermappings_server.go Updates fake server to v3 import and path parsing checks.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationprotectableitems_server.go Updates fake server to v3 import and path parsing checks.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationpolicies_server.go Updates fake server to v3 import and path parsing checks.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationnetworks_server.go Updates fake server to v3 import and path parsing checks.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationnetworkmappings_server.go Updates fake server to v3 import and path parsing checks.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationlogicalnetworks_server.go Updates fake server to v3 import and path parsing checks.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationjobs_server.go Updates fake server to v3 import and path parsing checks.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationfabrics_server.go Updates fake server to v3 import and path parsing checks.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationevents_server.go Updates fake server to v3 import and path parsing checks.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationeligibilityresults_server.go Updates fake server to v3 import and aligns regex path casing.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationappliances_server.go Updates fake server to v3 import and path parsing checks.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/replicationalertsettings_server.go Updates fake server to v3 import and path parsing checks.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/recoverypoints_server.go Updates fake server to v3 import and path parsing checks.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/operations_server.go Updates fake server to v3 import and path parsing checks.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/migrationrecoverypoints_server.go Updates fake server to v3 import and path parsing checks.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/internal.go Updates generator header to Go Code Generator.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/clusterrecoverypoints_server.go Updates fake server to v3 import and path parsing checks.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/fake/clusterrecoverypoint_server.go Updates fake server to v3 import and path parsing checks.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/clusterrecoverypoints_client_example_test.go Updates examples to v3 import and new response shapes.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/clusterrecoverypoints_client.go Regenerated pager client with updated API version and docs.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/clusterrecoverypoint_client_example_test.go Updates examples to v3 import and new response shapes.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/clusterrecoverypoint_client.go Regenerated client with updated API version and docs.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/client_factory.go Updates generator header and subscriptionID doc for v3.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/build.go Removes legacy go generate build hook (AutoRest-era).
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/autorest.md Removes AutoRest configuration (replaced by TypeSpec metadata).
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/README.md Updates install instructions to v3 module path.
sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/CHANGELOG.md Adds v3.0.0 release notes with breaking changes/features.
Comments suppressed due to low confidence (2)

sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/replicationeligibilityresults_client.go:1

  • The provider namespace segment is lowercased (providers/microsoft.Compute) while other paths in this SDK use canonical Microsoft.* casing. Even if ARM routing is case-insensitive, keeping canonical casing improves consistency and avoids edge cases with intermediaries/proxies. Consider switching these to providers/Microsoft.Compute (and align the fake server regex accordingly).
    sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery/replicationeligibilityresults_client.go:1
  • The provider namespace segment is lowercased (providers/microsoft.Compute) while other paths in this SDK use canonical Microsoft.* casing. Even if ARM routing is case-insensitive, keeping canonical casing improves consistency and avoids edge cases with intermediaries/proxies. Consider switching these to providers/Microsoft.Compute (and align the fake server regex accordingly).

// NewClientFactory creates a new instance of ClientFactory with the specified values.
// The parameter values will be propagated to any client created from this factory.
// - subscriptionID - The subscription Id.
// - subscriptionID - The ID of the target subscription. The value must be an UUID.
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar: use 'a UUID' instead of 'an UUID' in doc comments.

Suggested change
// - subscriptionID - The ID of the target subscription. The value must be an UUID.
// - subscriptionID - The ID of the target subscription. The value must be a UUID.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant