[AutoPR sdk-resourcemanager/servicegroups/armservicegroups]-generated-from-SDK Generation - Go-6712456 - #27403
Conversation
…Management/ServiceGroups/tspconfig.yaml', SDK Release Type: stable, and CommitSHA: '4cd7e2ac392a5d75c6a29fee14e93d2146364e79' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6712456 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
|
Azure Pipelines: Successfully started running 1 pipeline(s). 6 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
Updates the ServiceGroups ARM SDK generation inputs and Go dependencies to align with newer REST API specs and emitter output, and documents the resulting public API changes.
Changes:
- Bump spec commit reference and test metadata API version/emitter version.
- Update Go dependency
azcorefrom v1.22.0 to v1.23.0. - Add a
1.0.0changelog entry describing breaking changes and new features.
Reviewed changes
Copilot reviewed 4 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/resourcemanager/servicegroups/armservicegroups/tsp-location.yaml | Updates the referenced REST API specs commit for generation. |
| sdk/resourcemanager/servicegroups/armservicegroups/testdata/_metadata.json | Updates API version and emitter version used for test data/generation. |
| sdk/resourcemanager/servicegroups/armservicegroups/go.mod | Bumps azcore dependency version. |
| sdk/resourcemanager/servicegroups/armservicegroups/go.sum | Updates checksums for the new azcore version. |
| sdk/resourcemanager/servicegroups/armservicegroups/CHANGELOG.md | Adds 1.0.0 release notes including breaking changes and new APIs. |
Files not reviewed (16)
- sdk/resourcemanager/servicegroups/armservicegroups/client.go: Generated file
- sdk/resourcemanager/servicegroups/armservicegroups/client_example_test.go: Generated file
- sdk/resourcemanager/servicegroups/armservicegroups/client_factory.go: Generated file
- sdk/resourcemanager/servicegroups/armservicegroups/constants.go: Generated file
- sdk/resourcemanager/servicegroups/armservicegroups/fake/operations_server.go: Generated file
- sdk/resourcemanager/servicegroups/armservicegroups/fake/server.go: Generated file
- sdk/resourcemanager/servicegroups/armservicegroups/fake/server_factory.go: Generated file
- sdk/resourcemanager/servicegroups/armservicegroups/management_client.go: Generated file
- sdk/resourcemanager/servicegroups/armservicegroups/management_client_example_test.go: Generated file
- sdk/resourcemanager/servicegroups/armservicegroups/models.go: Generated file
- sdk/resourcemanager/servicegroups/armservicegroups/models_serde.go: Generated file
- sdk/resourcemanager/servicegroups/armservicegroups/operations_client.go: Generated file
- sdk/resourcemanager/servicegroups/armservicegroups/operations_client_example_test.go: Generated file
- sdk/resourcemanager/servicegroups/armservicegroups/options.go: Generated file
- sdk/resourcemanager/servicegroups/armservicegroups/responses.go: Generated file
- sdk/resourcemanager/servicegroups/armservicegroups/version.go: Generated file
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
…mservicegroups-6712456
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 19 changed files in this pull request and generated no new comments.
Files not reviewed (16)
- sdk/resourcemanager/servicegroups/armservicegroups/client.go: Generated file
- sdk/resourcemanager/servicegroups/armservicegroups/client_example_test.go: Generated file
- sdk/resourcemanager/servicegroups/armservicegroups/client_factory.go: Generated file
- sdk/resourcemanager/servicegroups/armservicegroups/constants.go: Generated file
- sdk/resourcemanager/servicegroups/armservicegroups/fake/operations_server.go: Generated file
- sdk/resourcemanager/servicegroups/armservicegroups/fake/server.go: Generated file
- sdk/resourcemanager/servicegroups/armservicegroups/fake/server_factory.go: Generated file
- sdk/resourcemanager/servicegroups/armservicegroups/management_client.go: Generated file
- sdk/resourcemanager/servicegroups/armservicegroups/management_client_example_test.go: Generated file
- sdk/resourcemanager/servicegroups/armservicegroups/models.go: Generated file
- sdk/resourcemanager/servicegroups/armservicegroups/models_serde.go: Generated file
- sdk/resourcemanager/servicegroups/armservicegroups/operations_client.go: Generated file
- sdk/resourcemanager/servicegroups/armservicegroups/operations_client_example_test.go: Generated file
- sdk/resourcemanager/servicegroups/armservicegroups/options.go: Generated file
- sdk/resourcemanager/servicegroups/armservicegroups/responses.go: Generated file
- sdk/resourcemanager/servicegroups/armservicegroups/version.go: Generated file
Suppressed comments (1)
sdk/resourcemanager/servicegroups/armservicegroups/CHANGELOG.md:8
- This breaking-change entry names a method that did not exist in the 0.1.0 API: the client constructor was the top-level
NewManagementClient, and that constructor remains present. Remove this entry so the release notes do not report a nonexistent removal.
- Function `*ManagementClient.NewClient` has been removed
⏳ Pipeline Checks Still RunningThe Action required: Re-trigger this workflow by removing and re-adding the |
Configurations: 'specification/management/resource-manager/Microsoft.Management/ServiceGroups/tspconfig.yaml', SDK Release Type: stable, and CommitSHA: '4cd7e2ac392a5d75c6a29fee14e93d2146364e79' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6712456 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=35595 Submitted by: meghanagupta@microsoft.com