[AutoPR sdk-resourcemanager/batch/armbatch]-generated-from-SDK Generation - Go-6712761

[azure-sdk-automation]

Configurations: 'specification/batch/resource-manager/Microsoft.Batch/Batch/tspconfig.yaml', SDK Release Type: stable, and CommitSHA: '3be251f9a92eb6ae68f4e3ee706f462541de316e' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6712761 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=35236 Submitted by: xingwu@microsoft.com

[azure-pipelines]

Azure Pipelines:
Successfully started running 1 pipeline(s).
6 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[Copilot]

Pull request overview

Note

Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.

Updates the Azure Batch ARM Go SDK package to a new major version (v5), aligning generated code, examples, and dependencies with the latest API/spec inputs.

Changes:

• Bump module major version from /v4 to /v5 and update docs/examples accordingly.
• Regenerate clients/pagers and response handling (including ETag field changes and pager request flow).
• Update spec commit reference and dependencies (e.g., azcore).

Reviewed changes

Copilot reviewed 15 out of 41 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
sdk/resourcemanager/batch/armbatch/version.go	Bumps internal module version to v5.0.0.
sdk/resourcemanager/batch/armbatch/tsp-location.yaml	Updates swagger/spec commit pointer used for generation.
sdk/resourcemanager/batch/armbatch/testdata/_metadata.json	Updates testdata metadata schema and emitter version.
sdk/resourcemanager/batch/armbatch/responses.go	Updates response structs/comments (including ETag-related fields).
sdk/resourcemanager/batch/armbatch/privatelinkresource_client_example_test.go	Updates import path to /v5 and example output shapes.
sdk/resourcemanager/batch/armbatch/privatelinkresource_client.go	Updates request/query encoding and pager nextLink handling.
sdk/resourcemanager/batch/armbatch/privateendpointconnection_client_example_test.go	Updates import path to /v5, fixes log message, updates example output shapes.
sdk/resourcemanager/batch/armbatch/privateendpointconnection_client.go	Updates request/query encoding and pager nextLink handling.
sdk/resourcemanager/batch/armbatch/pool_client_example_test.go	Updates import path to /v5 and example output shapes (ETag/time formatting updates).
sdk/resourcemanager/batch/armbatch/pool_client.go	Updates request/query encoding, ETag extraction, and pager nextLink handling.
sdk/resourcemanager/batch/armbatch/operations_client_example_test.go	Updates import path to /v5.
sdk/resourcemanager/batch/armbatch/go.sum	Updates dependency checksums (notably azcore).
sdk/resourcemanager/batch/armbatch/go.mod	Updates module path to /v5 and bumps azcore dependency.
sdk/resourcemanager/batch/armbatch/batchmanagement_live_test.go	Updates import path to /v5.
sdk/resourcemanager/batch/armbatch/README.md	Updates go get installation path to /v5.
sdk/resourcemanager/batch/armbatch/CHANGELOG.md	Adds v5.0.0 release notes, including ETag-related breaking changes.

Files not reviewed (25)

• sdk/resourcemanager/batch/armbatch/account_client.go: Generated file
• sdk/resourcemanager/batch/armbatch/account_client_example_test.go: Generated file
• sdk/resourcemanager/batch/armbatch/application_client.go: Generated file
• sdk/resourcemanager/batch/armbatch/application_client_example_test.go: Generated file
• sdk/resourcemanager/batch/armbatch/applicationpackage_client.go: Generated file
• sdk/resourcemanager/batch/armbatch/applicationpackage_client_example_test.go: Generated file
• sdk/resourcemanager/batch/armbatch/constants.go: Generated file
• sdk/resourcemanager/batch/armbatch/fake/account_server.go: Generated file
• sdk/resourcemanager/batch/armbatch/fake/application_server.go: Generated file
• sdk/resourcemanager/batch/armbatch/fake/applicationpackage_server.go: Generated file
• sdk/resourcemanager/batch/armbatch/fake/internal.go: Generated file
• sdk/resourcemanager/batch/armbatch/fake/location_server.go: Generated file
• sdk/resourcemanager/batch/armbatch/fake/networksecurityperimeter_server.go: Generated file
• sdk/resourcemanager/batch/armbatch/fake/operations_server.go: Generated file
• sdk/resourcemanager/batch/armbatch/fake/pool_server.go: Generated file
• sdk/resourcemanager/batch/armbatch/fake/privateendpointconnection_server.go: Generated file
• sdk/resourcemanager/batch/armbatch/fake/privatelinkresource_server.go: Generated file
• sdk/resourcemanager/batch/armbatch/fake/server_factory.go: Generated file
• sdk/resourcemanager/batch/armbatch/location_client.go: Generated file
• sdk/resourcemanager/batch/armbatch/location_client_example_test.go: Generated file
• sdk/resourcemanager/batch/armbatch/models.go: Generated file
• sdk/resourcemanager/batch/armbatch/models_serde.go: Generated file
• sdk/resourcemanager/batch/armbatch/networksecurityperimeter_client.go: Generated file
• sdk/resourcemanager/batch/armbatch/networksecurityperimeter_client_example_test.go: Generated file
• sdk/resourcemanager/batch/armbatch/operations_client.go: Generated file

Suppressed comments (7)

sdk/resourcemanager/batch/armbatch/responses.go:1

• The exported field name Etag doesn’t follow Go initialism conventions (expected ETag). Since this is a new major version, it’s a good opportunity to keep the idiomatic ETag spelling for public API consistency and readability; otherwise, please ensure all related doc comments also avoid referring to the field as ETag to prevent confusion.
  sdk/resourcemanager/batch/armbatch/responses.go:1
• The exported field name Etag doesn’t follow Go initialism conventions (expected ETag). Since this is a new major version, it’s a good opportunity to keep the idiomatic ETag spelling for public API consistency and readability; otherwise, please ensure all related doc comments also avoid referring to the field as ETag to prevent confusion.
  sdk/resourcemanager/batch/armbatch/responses.go:1
• The exported field name Etag doesn’t follow Go initialism conventions (expected ETag). Since this is a new major version, it’s a good opportunity to keep the idiomatic ETag spelling for public API consistency and readability; otherwise, please ensure all related doc comments also avoid referring to the field as ETag to prevent confusion.
  sdk/resourcemanager/batch/armbatch/responses.go:1
• The exported field name Etag doesn’t follow Go initialism conventions (expected ETag). Since this is a new major version, it’s a good opportunity to keep the idiomatic ETag spelling for public API consistency and readability; otherwise, please ensure all related doc comments also avoid referring to the field as ETag to prevent confusion.
  sdk/resourcemanager/batch/armbatch/responses.go:1
• The exported field name Etag doesn’t follow Go initialism conventions (expected ETag). Since this is a new major version, it’s a good opportunity to keep the idiomatic ETag spelling for public API consistency and readability; otherwise, please ensure all related doc comments also avoid referring to the field as ETag to prevent confusion.
  sdk/resourcemanager/batch/armbatch/pool_client.go:1
• For subsequent pages (nextLink != \"\"), the request no longer sets Accept: application/json. Previously runtime.FetcherForNextLink handled this; now the nextLink flow may send a request without the expected Accept header, which can affect content negotiation. Set the Accept header for both first-page and nextLink requests (and apply the same fix to the analogous pager implementations in privateendpointconnection_client.go and privatelinkresource_client.go).
  sdk/resourcemanager/batch/armbatch/pool_client.go:1
• Although Go canonicalizes header keys, using the conventional spelling ETag when reading the header improves clarity (it matches the HTTP header name and the surrounding comments). Consider switching resp.Header.Get(\"Etag\") back to resp.Header.Get(\"ETag\") for readability.

---

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

[ZiWei Chen (kazrael2119)]

spec pr is still opening