Migrate Identity Live tests deployment to Fed Auth. #42635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g2vinay
changed the title
…to update-identity-live-tests
g2vinay
force-pushed
the
update-identity-live-tests
branch
from
c8f73e7 to
3cd1232
Compare
weshaggard
reviewed
Oct 28, 2024
weshaggard
reviewed
Oct 28, 2024
weshaggard
approved these changes
Oct 30, 2024
weshaggard
reviewed
Nov 4, 2024
sdk/identity/azure-identity/src/test/java/LiveManagedIdentityTests.java
Outdated
Show resolved
Hide resolved
weshaggard
reviewed
Nov 4, 2024
weshaggard
reviewed
Nov 4, 2024
g2vinay
requested review from
KarishmaGhiya,
chlowell,
christothes,
maorleger and
mpodwysocki
g2vinay
commented
Nov 25, 2024
sdk/identity/azure-identity/src/test/java/com/azure/identity/implementation/RetryExtension.java
Show resolved
Hide resolved
weshaggard
reviewed
Nov 25, 2024
weshaggard
reviewed
Nov 25, 2024
weshaggard
reviewed
Nov 26, 2024
weshaggard
approved these changes
Nov 26, 2024
Member
weshaggard
left a comment
weshaggard
left a comment
There was a problem hiding this comment.
Probably some follow-ups needed but this gets us moved over to federated auth so I'm fine with it going it as is.
billwert
reviewed
Nov 26, 2024
sdk/identity/azure-identity/src/test/java/LiveManagedIdentityTests.java
Outdated
Show resolved
Hide resolved
billwert
reviewed
Nov 26, 2024
sdk/identity/azure-identity/src/test/java/LiveManagedIdentityTests.java
Outdated
Show resolved
Hide resolved
billwert
suggested changes
Nov 26, 2024
Contributor
billwert
left a comment
billwert
left a comment
There was a problem hiding this comment.
also as discussed offline please test the new-testresources.ps1 -userauth flow with these changes.
Member
Author
This is being handled in separate PR. |
billwert
reviewed
Dec 2, 2024
sdk/identity/azure-identity/src/test/java/com/azure/identity/implementation/RetryExtension.java
Show resolved
Hide resolved
billwert
approved these changes
Dec 2, 2024
Member
FYI |
Contributor
Oh, good context! @g2vinay meta point about testing the scenario stands tho. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates Tests to TME sub and use fed auth for deployment.
Adds retry extension to minimize transient failures of live tests.