-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Structured Message Decoder #44140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/storage/content-validation
Are you sure you want to change the base?
Structured Message Decoder #44140
Conversation
...e-common/src/main/java/com/azure/storage/common/implementation/StructuredMessageDecoder.java
Outdated
Show resolved
Hide resolved
...e-common/src/main/java/com/azure/storage/common/implementation/StructuredMessageDecoder.java
Outdated
Show resolved
Hide resolved
...e-common/src/main/java/com/azure/storage/common/implementation/StructuredMessageDecoder.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! This looks like a good start. I just had feedback on the initial API we should try to shoot for. After we get the public interfaces in a spot we like, I plan to look more closely into the tests and more into the details of the decoding implementation in follow up reviews.
...e-common/src/main/java/com/azure/storage/common/implementation/StructuredMessageDecoder.java
Outdated
Show resolved
Hide resolved
...e-common/src/main/java/com/azure/storage/common/implementation/StructuredMessageDecoder.java
Outdated
Show resolved
Hide resolved
...e-common/src/main/java/com/azure/storage/common/implementation/StructuredMessageDecoder.java
Outdated
Show resolved
Hide resolved
...e-common/src/main/java/com/azure/storage/common/implementation/StructuredMessageDecoder.java
Outdated
Show resolved
Hide resolved
...e-common/src/main/java/com/azure/storage/common/implementation/StructuredMessageDecoder.java
Outdated
Show resolved
Hide resolved
...e-common/src/main/java/com/azure/storage/common/implementation/StructuredMessageDecoder.java
Outdated
Show resolved
Hide resolved
...e-common/src/main/java/com/azure/storage/common/implementation/StructuredMessageDecoder.java
Outdated
Show resolved
Hide resolved
...e-common/src/main/java/com/azure/storage/common/implementation/StructuredMessageDecoder.java
Outdated
Show resolved
Hide resolved
API change check APIView has identified API level changes in this PR and created following API reviews. |
Hi @ibrahimrabab. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
comment |
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines