Skip to content

Add support for passing access tokens to com.azure.security.keyvault.jca for use in Azure devops #44878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

woerdeka
Copy link

@woerdeka woerdeka commented Apr 3, 2025

Description

  • Added the "azure.keyvault.access-token" parameter to the com.azure.security.keyvault.jca library allow one to pass an access token directly. This way, it is possible to use
( az account get-access-token --scope https://vault.azure.net/.default | ConvertFrom-Json ).accessToken

to obtain an access token for accessing a keyvault, and pass that to the signing library. This is needed to be able to use federated authentication with service connections in Azure devops.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added azure-spring All azure-spring related issues Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Apr 3, 2025
Copy link
Contributor

github-actions bot commented Apr 3, 2025

Thank you for your contribution @woerdeka! We will review the pull request and get back to you soon.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure:azure-security-keyvault-jca

@woerdeka
Copy link
Author

woerdeka commented Apr 3, 2025

@microsoft-github-policy-service agree company="Keenfinity Group"

@woerdeka
Copy link
Author

woerdeka commented Apr 3, 2025

I really don't understand what is causing the build errors. It does not seem to be related to my changes.

Copy link
Contributor

@woerdeka the command you issued was incorrect. Please try again.

Examples are:

@microsoft-github-policy-service agree

and

@microsoft-github-policy-service agree company="your company"

@woerdeka
Copy link
Author

@microsoft-github-policy-service agree company="Keenfinity Group"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants