Skip to content

Increase test coverage for OpenAIAsyncClient and OpenAIClient #44998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Increase test coverage for OpenAIAsyncClient and OpenAIClient #44998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions ...enai/azure-ai-openai/src/test/java/com/azure/ai/openai/NonAzureOpenAIAsyncClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
import com.azure.ai.openai.models.ChatCompletionsFunctionToolSelection;
import com.azure.ai.openai.models.ChatCompletionsNamedFunctionToolSelection;
import com.azure.ai.openai.models.ChatCompletionsOptions;
import com.azure.ai.openai.models.ChatCompletionStreamOptions;
import com.azure.ai.openai.models.ChatCompletionsToolCall;
import com.azure.ai.openai.models.ChatCompletionsToolSelection;
import com.azure.ai.openai.models.ChatCompletionsToolSelectionPreset;
Expand Down Expand Up @@ -2131,4 +2132,32 @@ public void testListBatchesFailure(HttpClient httpClient, OpenAIServiceVersion s
assertNotNull(httpResponseException.getMessage());
});
}

@ParameterizedTest(name = DISPLAY_NAME_WITH_ARGUMENTS)
@MethodSource("com.azure.ai.openai.TestUtils#getTestParameters")
public void testGetCompletionsStreamEmitsValues(HttpClient httpClient, OpenAIServiceVersion serviceVersion) {
client = getNonAzureOpenAIAsyncClient(httpClient);

getCompletionsRunnerForNonAzure((deploymentId, prompt) -> {
StepVerifier.create(client.getCompletionsStream(deploymentId, new CompletionsOptions(prompt),
new ChatCompletionStreamOptions())).recordWith(ArrayList::new).thenConsumeWhile(completion -> {
assertNotNull(completion);
return true;
}).consumeRecordedWith(messageList -> assertFalse(messageList.isEmpty())).verifyComplete();
});
}

@ParameterizedTest(name = DISPLAY_NAME_WITH_ARGUMENTS)
@MethodSource("com.azure.ai.openai.TestUtils#getTestParameters")
public void testGetChatCompletionsStreamEmitsValues(HttpClient httpClient, OpenAIServiceVersion serviceVersion) {
client = getNonAzureOpenAIAsyncClient(httpClient);

getChatCompletionsRunnerForNonAzure((deploymentId, prompt) -> {
StepVerifier.create(client.getChatCompletionsStream(deploymentId, new ChatCompletionsOptions(prompt),
new ChatCompletionStreamOptions())).recordWith(ArrayList::new).thenConsumeWhile(chatCompletion -> {
assertNotNull(chatCompletion);
return true;
}).consumeRecordedWith(messageList -> assertFalse(messageList.isEmpty())).verifyComplete();
});
}
}
28 changes: 28 additions & 0 deletions ...penai/azure-ai-openai/src/test/java/com/azure/ai/openai/NonAzureOpenAISyncClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import com.azure.ai.openai.models.ChatCompletionsFunctionToolSelection;
import com.azure.ai.openai.models.ChatCompletionsNamedFunctionToolSelection;
import com.azure.ai.openai.models.ChatCompletionsOptions;
import com.azure.ai.openai.models.ChatCompletionStreamOptions;
import com.azure.ai.openai.models.ChatCompletionsToolCall;
import com.azure.ai.openai.models.ChatCompletionsToolSelection;
import com.azure.ai.openai.models.ChatCompletionsToolSelectionPreset;
Expand Down Expand Up @@ -52,6 +53,7 @@
import com.azure.core.util.BinaryData;
import com.azure.core.util.CoreUtils;
import com.azure.core.util.IterableStream;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.MethodSource;

Expand Down Expand Up @@ -1796,4 +1798,30 @@ public void testListBatchesFailure(HttpClient httpClient, OpenAIServiceVersion s
assertEquals(400, exception.getResponse().getStatusCode());
assertNotNull(exception.getMessage());
}

@ParameterizedTest(name = DISPLAY_NAME_WITH_ARGUMENTS)
@MethodSource("com.azure.ai.openai.TestUtils#getTestParameters")
public void testGetCompletionsStreamEmitsValues(HttpClient httpClient, OpenAIServiceVersion serviceVersion) {
client = getNonAzureOpenAISyncClient(httpClient);

getCompletionsRunnerForNonAzure((deploymentId, prompt) -> {
IterableStream<Completions> completionsList = client.getCompletionsStream(deploymentId,
new CompletionsOptions(prompt), new ChatCompletionStreamOptions());

completionsList.forEach(Assertions::assertNotNull);
});
}

@ParameterizedTest(name = DISPLAY_NAME_WITH_ARGUMENTS)
@MethodSource("com.azure.ai.openai.TestUtils#getTestParameters")
public void testGetChatCompletionsEmitsValues(HttpClient httpClient, OpenAIServiceVersion serviceVersion) {
client = getNonAzureOpenAISyncClient(httpClient);

getChatCompletionsRunnerForNonAzure((deploymentId, prompt) -> {
IterableStream<ChatCompletions> chatCompletionsList = client.getChatCompletionsStream(deploymentId,
new ChatCompletionsOptions(prompt), new ChatCompletionStreamOptions());

chatCompletionsList.forEach(Assertions::assertNotNull);
});
}
}
29 changes: 29 additions & 0 deletions sdk/openai/azure-ai-openai/src/test/java/com/azure/ai/openai/OpenAIAsyncClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
import com.azure.ai.openai.models.Completions;
import com.azure.ai.openai.models.CompletionsFinishReason;
import com.azure.ai.openai.models.CompletionsOptions;
import com.azure.ai.openai.models.ChatCompletionStreamOptions;
import com.azure.ai.openai.models.CompletionsUsage;
import com.azure.ai.openai.models.Embeddings;
import com.azure.ai.openai.models.FileDeletionStatus;
Expand Down Expand Up @@ -2323,4 +2324,32 @@ public void testListBatchesFailure(HttpClient httpClient, OpenAIServiceVersion s
assertNotNull(httpResponseException.getMessage());
});
}

@ParameterizedTest(name = DISPLAY_NAME_WITH_ARGUMENTS)
@MethodSource("com.azure.ai.openai.TestUtils#getTestParameters")
public void testGetCompletionsStreamEmitsValues(HttpClient httpClient, OpenAIServiceVersion serviceVersion) {
client = getOpenAIAsyncClient(httpClient, serviceVersion);

getCompletionsRunner((deploymentId, prompt) -> {
StepVerifier.create(client.getCompletionsStream(deploymentId, new CompletionsOptions(prompt),
new ChatCompletionStreamOptions())).recordWith(ArrayList::new).thenConsumeWhile(completion -> {
assertNotNull(completion);
return true;
}).consumeRecordedWith(messageList -> assertFalse(messageList.isEmpty())).verifyComplete();
});
}

@ParameterizedTest(name = DISPLAY_NAME_WITH_ARGUMENTS)
@MethodSource("com.azure.ai.openai.TestUtils#getTestParameters")
public void testGetChatCompletionsStreamEmitsValues(HttpClient httpClient, OpenAIServiceVersion serviceVersion) {
client = getOpenAIAsyncClient(httpClient, serviceVersion);

getChatCompletionsRunner((deploymentId, prompt) -> {
StepVerifier.create(client.getChatCompletionsStream(deploymentId, new ChatCompletionsOptions(prompt),
new ChatCompletionStreamOptions())).recordWith(ArrayList::new).thenConsumeWhile(chatCompletion -> {
assertNotNull(chatCompletion);
return true;
}).consumeRecordedWith(messageList -> assertFalse(messageList.isEmpty())).verifyComplete();
});
}
}
28 changes: 28 additions & 0 deletions sdk/openai/azure-ai-openai/src/test/java/com/azure/ai/openai/OpenAISyncClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import com.azure.ai.openai.models.ChatCompletionsFunctionToolSelection;
import com.azure.ai.openai.models.ChatCompletionsNamedFunctionToolSelection;
import com.azure.ai.openai.models.ChatCompletionsOptions;
import com.azure.ai.openai.models.ChatCompletionStreamOptions;
import com.azure.ai.openai.models.ChatCompletionsToolCall;
import com.azure.ai.openai.models.ChatCompletionsToolSelection;
import com.azure.ai.openai.models.ChatCompletionsToolSelectionPreset;
Expand Down Expand Up @@ -56,6 +57,7 @@
import com.azure.core.util.BinaryData;
import com.azure.core.util.CoreUtils;
import com.azure.core.util.IterableStream;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.MethodSource;
Expand Down Expand Up @@ -1981,4 +1983,30 @@ public void testListBatchesFailure(HttpClient httpClient, OpenAIServiceVersion s
assertEquals(400, exception.getResponse().getStatusCode());
assertNotNull(exception.getMessage());
}

@ParameterizedTest(name = DISPLAY_NAME_WITH_ARGUMENTS)
@MethodSource("com.azure.ai.openai.TestUtils#getTestParameters")
public void testGetCompletionsStreamEmitsValues(HttpClient httpClient, OpenAIServiceVersion serviceVersion) {
client = getOpenAIClient(httpClient, serviceVersion);

getCompletionsRunner((deploymentId, prompt) -> {
IterableStream<Completions> completionsList = client.getCompletionsStream(deploymentId,
new CompletionsOptions(prompt), new ChatCompletionStreamOptions());

completionsList.forEach(Assertions::assertNotNull);
});
}

@ParameterizedTest(name = DISPLAY_NAME_WITH_ARGUMENTS)
@MethodSource("com.azure.ai.openai.TestUtils#getTestParameters")
public void testGetChatCompletionsEmitsValues(HttpClient httpClient, OpenAIServiceVersion serviceVersion) {
client = getOpenAIClient(httpClient, serviceVersion);

getChatCompletionsRunner((deploymentId, prompt) -> {
IterableStream<ChatCompletions> chatCompletionsList = client.getChatCompletionsStream(deploymentId,
new ChatCompletionsOptions(prompt), new ChatCompletionStreamOptions());

chatCompletionsList.forEach(Assertions::assertNotNull);
});
}
}
Loading