Skip to content

[TESTING ONLY] Testing common changes required for duplicate artifactId #45181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

JimSuplizio
Copy link
Member

@JimSuplizio JimSuplizio commented May 1, 2025

I'm testing changes to API review creation. These changes will pass a list of PackageInfo files instead of a list of Artifact.Names. This allows passing around the PackageInfo object instead random pieces of data. Passing around the PackageInfo object also allows the FindArtifactForApiReviewFnV2 to correctly, and easily, find the sources jar since the PackageInfo file contains the Group. This eliminates the janky code that had to exist in the original FindArtifactForApiReviewFn which had to play a guessing game with the group to get correct path to the sources.jar

The other changes are to update the detect-api-changes, updating to use the FindArtifactForApiReviewFnV2 instead of the FindArtifactForApiReviewFn also, in some cases, pass the PackageInfo file to functions so we're not loading the same PackageInfo multiple times.

validate-all-packages changes

  • Validate-All-PackagesV2.ps1 takes in a list of PackageInfo files.
  • Validate-All-PackagesV2.ps1 folds in what was originally in Validate-Package.ps1, which is only called by Validate-All-Packages, into the script instead of making another script call.
  • Refactor what was in Update-DevOps-Release-WorkItem.ps1, moving the contents of this script into a function, Update-DevOpsReleaseWorkItem, in DevOps-WorkItem-Helpers.ps1
  • Move the az login and azure-devops extension checks into a function, CheckAzLoginAndDevOpsExtensionInstall, in DevOps-WorkItem-Helpers.ps1.
  • CheckAzLoginAndDevOpsExtensionInstall and CheckDevOpsAccess both check, and set, global variables to see if their respective actions have already been done.
  • Part of the refactoring work done here is because both Validate-Package.ps1 and Update-DevOps-Release-WorkItem.ps1, when called as separate scripts, both had to az login, azure-devops extension install and devops access. Because these were separate scripts calls, there's no real way to save any kind of state so all of these checks were made for every artifact being processed.

Testing changes to this, at least for create-apireview.yml, requires a pipeline to be manually kicked off against the refs/merge of this PR to test yml path for PackageInfo files and the new script.

@JimSuplizio JimSuplizio added the Central-EngSys This issue is owned by the Engineering System team. label May 1, 2025
@JimSuplizio JimSuplizio self-assigned this May 1, 2025
JimSuplizio and others added 21 commits May 1, 2025 10:31
…actored what was in Validate-Package.ps1 into its script
* stg98 versioning changes (Azure#44033)

* Stg98/versions (Azure#44079)

* stg98 versioning changes

* resolving merge conflicts

* adding missing service version in transformutils

* fixing formatting issues

---------

Co-authored-by: Isabelle <[email protected]>

* adding tests for get sect ACL using OAuth (Azure#44664)

* adding tests for get sect ACL using OAuth

* fixing tests for get sect ACL using OAuth

* resolving PR comments and adding recordings

* changing min service version to 2025-07-05 and adding datalake recordings

---------

Co-authored-by: Isabelle <[email protected]>

* STG98 - NFS over REST (Azure#44268)

* stg98 nfsoverrest feature changes

* fixing swagger customization

* stg98 nfsoverrest feature changes - resolving PR comments

* comments and formatting

* resolving PR comments

* adding tests for sync and aysnc apis

* fixing tests

* fixing linting errors

* fixing linting errors

* resolving PR comments and adding recordings

* fixing oAuth tests and adding recordings for them

* resolving final PR comments

* adding new header to sanitizer

---------

Co-authored-by: Isabelle <[email protected]>

* STG98 - x-ms-file-request-intent support for blob copy (Azure#44269)

* stg98 file intent header changes

* stg98 renaming fileShareTokenIntent to sourceShareTokenIntent

* resolving PR comments

* adding tests for filerequestintentheader

* adding token intent to share clients to fix test issue

* resolving PR comments

* fixing formatting issues

* wip of blob tests without file dependency

* adding file upload and creation using httppipeline

* adding delete util for deleting share using httppipeline

* refactoring helper methods

* changing FileShareTokenIntent to a custom type

* addressing comments

* using the public apis instead of protected in tests, making sure to use the oauth clients, and making tests look more similar

* fixing ImmutableStorageWithVersioningTests, removing account name and management plane api final variables from test base as theyre different across tests

* ci

* actually fixing ci

---------

Co-authored-by: Isabelle <[email protected]>

* resolving asset file merge conflicts

* removing testproxyreroute.log file

* adding two linefeeds after signedCorrelationId in stringToSign

* adding two linefeeds in stringToSign

* fixing formatting issues

* fixing sas service version and adding new lines in string to sign

* adjusting manually constructed user delegation tests and fixing format

* adjusting tests i missed

---------

Co-authored-by: Isabelle <[email protected]>
…1.4 (Azure#45198)

* Moving avro dependency in azure-cosmos-kafka-connect to 1.11.4

* Update external_dependencies.txt
Add try-with-resources to annotation processor
* Identity May GA cleanup

* update changelog

* more clenaups

* delete an unused class

* Add a check for service fabric using user-assigned identity.

* spotless

* pr feedback
* code cleanup: remove some old MI tests which no longer are necessary and a couple constants.

* helper for getting an HttpClient that will return a sequence of responses.

* Throw CredentialUnavailableException for cases where IMDS returns invalid JSON.

* spotless

* fix test to expect new exception

* use a logger instead of println

* fix ordering

* wip

* wip

* Remove an opportunistic change I was trying to make to move away from HttpURLConnection. There's too many details of how precisely to do this to work out for the moment.

* fix error message

* remove currently unused test helper method.

* spotless
* Add ReadConsistencyStrategy API

* Adding test coverage

* Update ClientConfigDiagnosticsTest.java

* Update ConsistencyReaderTest.java

* Update SessionTest.java

* Update OperationPoliciesTest.java

* Update OperationPoliciesTest.java

* Update ReadConsistencyStrategy.java

* Reacted to code review feedback

* Update sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/CosmosChangeFeedRequestOptions.java

Co-authored-by: Abhijeet Mohanty <[email protected]>

* Update ReadConsistencyStrategy.java

---------

Co-authored-by: Abhijeet Mohanty <[email protected]>
…45196)

* Enabled `excludeRegions` to be applied for `QueryPlan` calls.

* Enabled `excludeRegions` to be applied for `QueryPlan` calls.
* Add live test case for storage actions

* fix commits
* Added user agent suffixing if PPAF / PPCB are opted into at client-level.

* Added user agent suffixing if PPAF / PPCB are opted into at client-level.

* Added user agent suffixing if PPAF / PPCB are opted into at client-level.

* Added user agent suffixing if PPAF / PPCB are opted into at client-level.

* Added user agent suffixing if PPAF / PPCB are opted into at client-level.

* Addressing review comments.

* Addressing review comments.
scriptLocation: inlineScript
inlineScript: |
$(Build.SourcesDirectory)/eng/common/scripts/Validate-All-Packages.ps1 `
-ArtifactList ('${{ convertToJson(parameters.Artifacts) }}' | ConvertFrom-Json | Select-Object Name) `
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's take and convert this ArtifactList to a set of PackageInfoFiles and eliminate the need to bifurcate the scripts.

@@ -271,9 +271,10 @@ stages:
ArtifactPath: $(Pipeline.Workspace)/packages-signed
- template: /eng/common/pipelines/templates/steps/create-apireview.yml
parameters:
PackageInfoFiles:
- ${{ each artifact in parameters.Artifacts }}:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are already doing the mapping from artifact to package info right here. You can do that for everyone and not need to bifurcate all the scripts.

azure-sdk and others added 2 commits May 6, 2025 09:31
)

* Add helper function for spec-gen-sdk pipeline

* Move logging script sourceing to global scope

---------

Co-authored-by: Chidozie Ononiwu <[email protected]>
azure-sdk and others added 27 commits May 8, 2025 12:58
…pconfig.yaml', API Version: 2024-08-21-preview, SDK Release Type: beta, and CommitSHA: '121c5e84647a9cdb1767d5146affdfe2af91d776' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' (Azure#45253)
…m-spec-gen-sdk - java-4783229 (Azure#45056)

* Configurations:  'specification/programmableconnectivity/ProgrammableConnectivity.Management/tspconfig.yaml', API Version: 2024-01-15-preview, SDK Release Type: beta, and CommitSHA: 'e6c1765120cdfe6f054348d5432218f630be2635' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs'

* Update pom.xml

* regen

---------

Co-authored-by: Weidong Xu <[email protected]>
…en-sdk - java-4841700 (Azure#45256)

* Configurations:  'specification/liftrweightsandbiases/Liftr.WeightsAndBiases.Management/tspconfig.yaml', API Version: 2024-09-18, SDK Release Type: stable, and CommitSHA: '121c5e84647a9cdb1767d5146affdfe2af91d776' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs'

* Update CHANGELOG.md

---------

Co-authored-by: Hong Li(MSFT) <[email protected]>
….yaml', API Version: 2025-03-21-preview, SDK Release Type: beta, and CommitSHA: '121c5e84647a9cdb1767d5146affdfe2af91d776' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' (Azure#45255)

Co-authored-by: Xiaofei Cao <[email protected]>
…m-spec-gen-sdk - java-4841513 (Azure#45254)

* Configurations:  'specification/liftrarize/ArizeAi.ObservabilityEval.Management/tspconfig.yaml', API Version: 2024-10-01, SDK Release Type: stable, and CommitSHA: '121c5e84647a9cdb1767d5146affdfe2af91d776' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs'

* changelog

---------

Co-authored-by: xiaofeicao <[email protected]>
Co-authored-by: Xiaofei Cao <[email protected]>
… availability strategy. (Azure#45244)

* Allow hedged request to mark operation success status.

* Allow hedged request to mark operation success status.

* Allow hedged request to mark operation success status.

* Fix `OperationCanceledException` handling for queries.

* Fix `OperationCanceledException` handling for queries.

* Fixing buggy tests.

* Fixing buggy tests.

* Addressing review comments.
Disable verify readmes

This is causing problems in the pullrequest pipeline. After talking to @weshaggard we're turning it off since it is a low value check.
…spconfig.yaml', API Version: 2025-03-01-preview, SDK Release Type: beta, and CommitSHA: '442e662b6705b3408e0f5581703252053e90fa5b' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' (Azure#45261)
…tspconfig.yaml', API Version: 2024-11-18-preview, SDK Release Type: beta, and CommitSHA: '9f69db7532b6706baedc004f2eda762196a3e1eb' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' (Azure#45268)
* update autorest.java

* disable sync-stack for premium
…actored what was in Validate-Package.ps1 into its script
@JimSuplizio JimSuplizio closed this May 9, 2025
@JimSuplizio
Copy link
Member Author

I love how well rebase works. Closing this PR.

@JimSuplizio JimSuplizio deleted the TestingCommonChangesForDupArtifactName2 branch May 9, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.