Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jun 24, 2025

Summary

This PR removes the LinuxImageDemand and WindowsImageDemand variables from all image.yml files and replaces their usage with hardcoded string values. This aligns with the changes made in Azure/azure-sdk-for-net#50802.

Changes Made

  1. Removed variable definition: Deleted LinuxImageDemand variable from /eng/pipelines/templates/variables/image.yml
  2. Replaced variable usage: Updated /eng/pipelines/docindex.yml to use the hardcoded value ImageOverride -equals ubuntu-24.04 instead of $(LinuxImageDemand)
  3. Confirmed WindowsImageDemand: Verified that WindowsImageDemand was not present in the codebase

Before

# image.yml
- name: LinuxImageDemand
  value: ImageOverride -equals $(LINUXVMIMAGE)

# docindex.yml
pool:
  name: $(LINUXPOOL)
  demands: $(LinuxImageDemand)

After

# image.yml
# LinuxImageDemand variable removed

# docindex.yml
pool:
  name: $(LINUXPOOL)
  demands: ImageOverride -equals ubuntu-24.04

Validation

  • ✅ YAML syntax validation passed for all modified files
  • ✅ Confirmed no remaining references to either variable in the entire codebase
  • ✅ Changes are minimal and surgical (2 files, 4 lines changed)
  • ✅ Hardcoded value correctly resolves the original variable expression

The replacement value ImageOverride -equals ubuntu-24.04 was determined by resolving the original variable definition: LinuxImageDemand = "ImageOverride -equals $(LINUXVMIMAGE)" where LINUXVMIMAGE = "ubuntu-24.04".


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Copilot AI changed the title [WIP] Remove LinuxImageDemand and WindowsImageDemand from image.yml and replace usages with variable values Remove LinuxImageDemand and WindowsImageDemand variables from pipeline configuration Jun 24, 2025
Copilot AI requested a review from weshaggard June 24, 2025 00:17
@weshaggard weshaggard marked this pull request as ready for review June 24, 2025 00:21
Copilot AI review requested due to automatic review settings June 24, 2025 00:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the intermediary LinuxImageDemand variable from the pipeline configuration and replaces its usage with a hardcoded string value to align with changes in the Azure/azure-sdk-for-net repository.

  • Removed the LinuxImageDemand variable definition from eng/pipelines/templates/variables/image.yml.
  • Updated eng/pipelines/docindex.yml to use the hardcoded value "ImageOverride -equals ubuntu-24.04" in place of the variable.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
eng/pipelines/templates/variables/image.yml Removed the LinuxImageDemand variable to eliminate unnecessary indirection.
eng/pipelines/docindex.yml Replaced variable reference with a hardcoded string value.
Comments suppressed due to low confidence (2)

eng/pipelines/docindex.yml:31

  • [nitpick] Consider adding an inline comment explaining why the literal value is used instead of a variable to improve future clarity and maintainability.
      demands: ImageOverride -equals ubuntu-24.04

Copilot AI requested a review from weshaggard June 24, 2025 00:41
@weshaggard weshaggard merged commit 4edce0c into main Jun 24, 2025
13 checks passed
@weshaggard weshaggard deleted the copilot/fix-b722fb92-9bce-4e91-978a-fe8512b1fb7b branch June 24, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants