Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jun 24, 2025

Summary

This PR removes the deprecated LinuxImageDemand and WindowsImageDemand variables from pipeline configuration files and replaces hardcoded ubuntu-24.04 references with the standardized $(LINUXVMIMAGE) variable. This aligns with the changes made in Azure/azure-sdk-for-net#50802 and follows the latest pipeline configuration requirements.

Changes Made

Variable Removal

  • Removed LinuxImageDemand variable definition from /eng/pipelines/templates/variables/image.yml
  • Confirmed no WindowsImageDemand variables existed in the codebase

Pipeline Updates

  • Updated /eng/pipelines/docindex.yml:
    # Before
    demands: $(LinuxImageDemand)
    
    # After  
    demands: ImageOverride -equals $(LINUXVMIMAGE)

Hardcoded Value Replacements

Replaced hardcoded ubuntu-24.04 with $(LINUXVMIMAGE) in the following files:

  • /eng/common/pipelines/codeowners-linter.yml
  • /eng/common/pipelines/templates/stages/archetype-sdk-tool-pwsh.yml
  • /eng/common/pipelines/templates/jobs/archetype-sdk-tests-generate.yml

Files Intentionally Unchanged

  • npm-publish.yml: Left unchanged due to deployment job constraints (documented in comments explaining hardcoding is necessary)
  • image.yml variable definitions: Correctly define LINUXVMIMAGE value as ubuntu-24.04
  • GitHub workflows: Use GitHub Actions syntax, not Azure DevOps variables

Validation

  • ✅ All modified YAML files validated for syntax correctness
  • ✅ Created and ran verification tests to ensure proper variable usage
  • ✅ Confirmed consistent usage of ImageOverride -equals $(LINUXVMIMAGE) pattern
  • ✅ Verified no remaining references to removed variables exist

Impact

This change standardizes pipeline image references across the repository and removes deprecated variables while maintaining full backward compatibility. Pipelines will continue to use the same underlying Ubuntu 24.04 image but now reference it through the centralized $(LINUXVMIMAGE) variable.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@weshaggard weshaggard closed this Jun 24, 2025
Copilot AI changed the title [WIP] Remove LinuxImageDemand and WindowsImageDemand from image.yml, use $(LINUXVMIMAGE) instead of hardcoded ubuntu-24.04 Remove LinuxImageDemand and WindowsImageDemand variables, replace hardcoded ubuntu-24.04 with $(LINUXVMIMAGE) Jun 24, 2025
Copilot AI requested a review from weshaggard June 24, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants