Fix on_behalf_of grant_type duplication in Spring Security 6.5+ #47667
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Spring Security 6.5+, chaining parameter converters via
addParametersConverter()causesgrant_typeto duplicate as a list[jwt-bearer, jwt-bearer]instead of remaining a single value, triggeringAADSTS70003: unsupported grant type.Root cause:
addParametersConverter()usesMultiValueMap.addAll()which appends to existing keys. When the deprecatedsuper.createParameters()usesparameters.add()and a chained converter also adds the same key, values accumulate into a list.Changes
createParameters()to useparameters.set()throughout, ensuring single valuessuper.createParameters()call to avoid inheritance from deprecated implementation usingadd()DefaultOAuth2TokenRequestParametersConverterCLIENT_SECRET_BASIC: credentials in Authorization header onlyCLIENT_SECRET_POST: credentials in POST body parametersclient_idin parameters onlyBefore
After
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.