Sync eng/common directory with azure-sdk-tools for PR 14293#48362
Sync eng/common directory with azure-sdk-tools for PR 14293#48362
Conversation
azure-sdk
added
EngSys
There was a problem hiding this comment.
Pull request overview
Syncs eng/common content with the upstream azure-sdk-tools changes (tools PR 14293), updating the enforcement logic and documentation around .github/* sync branches and restricted file patterns.
Changes:
- Broadened
.githubsync branch naming expectations (fromsync-.github/workflowstosync-.github). - Expanded the workflow enforcer’s restricted
.github/*paths to include.github/skills/azsdk-common-*/**. - Updated enforcement messaging/display name to reflect broader
.githubscope.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| eng/common/scripts/Delete-RemoteBranches.ps1 | Updates guidance comment for .github sync branch regex. |
| eng/common/pipelines/templates/steps/eng-common-workflow-enforcer.yml | Broadens .github sync prefix check and expands restricted .github/* file patterns and messaging. |
| # We start from the sync PRs, use the branch name to get the PR number of central repo. E.g. sync-eng/common-(<branchName>)-(<PrNumber>). Have group name on PR number. | ||
| # For sync-eng/common work, we use regex as "^sync-eng/common.*-(?<PrNumber>\d+).*$". | ||
| # For sync-.github/workflows work, we use regex as "^sync-.github/workflows.*-(?<PrNumber>\d+).*$". | ||
| # For sync-.github work, we use regex as "^sync-.github.*-(?<PrNumber>\d+).*$". |
There was a problem hiding this comment.
The example regex in this comment uses sync-.github, but in regex . matches any character. If this is intended to match the literal .github prefix, the dot should be escaped (e.g., sync-\.github). Otherwise readers copying this will end up matching more branches than intended.
| # For sync-.github work, we use regex as "^sync-.github.*-(?<PrNumber>\d+).*$". | |
| # For sync-.github work, we use regex as "^sync-\.github.*-(?<PrNumber>\d+).*$". |
| { | ||
| # This list needs to be kept in sync with the FilePatterns listed in eng/pipelines/eng-workflows-sync.yml | ||
| $filePatterns = @(".github/workflows/*event*", ".github/workflows/post-apiview.yml") | ||
| # This list needs to be kept in sync with the FilePatterns listed in eng/pipelines/eng-github-config-sync.yml |
There was a problem hiding this comment.
This comment references eng/pipelines/eng-github-config-sync.yml, but that file doesn't exist in this repo. This makes the “kept in sync” instruction non-actionable/misleading; please either update the reference to an existing file/path in this repo or link to the corresponding file in azure-sdk-tools (since that’s where the source of truth appears to live).
| # This list needs to be kept in sync with the FilePatterns listed in eng/pipelines/eng-github-config-sync.yml | |
| # This list needs to be kept in sync with the FilePatterns listed in | |
| # https://github.com/Azure/azure-sdk-tools/blob/main/eng/pipelines/eng-github-config-sync.yml |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#14293 See eng/common workflow