Fix DLQ reason and description not transmitted in ServiceBus binder

[rujche]

Summary

• Remove the redundant no-arg messageContext.deadLetter() call in ServiceBusMessageChannelBinder.deadLetter(...).
• Keep only messageContext.deadLetter(options) so the dead-letter reason and error description are applied correctly.
• Strengthen regression test to verify the no-arg overload is never invoked.

Root Cause

The no-arg deadLetter() settled the message before the parameterized deadLetter(options) call executed, so DLQ reason/description were not transmitted.

Changes

• ServiceBusMessageChannelBinder: deleted the no-arg dead-letter call.
• ServiceBusMessageChannelBinderTest: added verify(messageContext, never()).deadLetter().

Verification

• Ran:
  • mvn -pl sdk/spring/spring-cloud-azure-stream-binder-servicebus -Dtest=ServiceBusMessageChannelBinderTest test -DskipITs
• Result:
  • BUILD SUCCESS
  • Tests run: 3, Failures: 0, Errors: 0

Fixes #41883

[Copilot]

Pull request overview

This PR fixes a regression in the Spring Cloud Azure Service Bus Stream Binder where dead-letter reason and error description were not being transmitted because the message was being settled by an earlier no-arg deadLetter() call before deadLetter(options) could apply the options.

Changes:

• Removed the redundant no-arg deadLetter() invocation so only deadLetter(DeadLetterOptions) is used.
• Strengthened the regression test to assert the no-arg overload is never called and that there are no unexpected interactions.
• Added a Spring module changelog entry documenting the bug fix.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
sdk/spring/spring-cloud-azure-stream-binder-servicebus/src/main/java/com/azure/spring/cloud/stream/binder/servicebus/implementation/ServiceBusMessageChannelBinder.java	Removes the premature no-arg dead-letter settlement so reason/description can be applied via DeadLetterOptions.
sdk/spring/spring-cloud-azure-stream-binder-servicebus/src/test/java/com/azure/spring/cloud/stream/binder/servicebus/implementation/ServiceBusMessageChannelBinderTest.java	Adds assertions ensuring deadLetter() (no-arg) is never invoked and no extra interactions occur.
sdk/spring/CHANGELOG.md	Documents the regression fix under the unreleased Spring Cloud Azure Stream Binder Service Bus section.

[sunghyun1999]

Hi @rujche, thanks for picking this up! Since this fix originated from my PR #49662, would you mind adding a Co-authored-by trailer to credit the original contribution? Thanks!

Co-authored-by: sunghyun1999 <32184099@dankook.ac.kr>

[rujche]

Hi @rujche, thanks for picking this up! Since this fix originated from my PR #49662, would you mind adding a Co-authored-by trailer to credit the original contribution? Thanks!

Co-authored-by: sunghyun1999 <32184099@dankook.ac.kr>

@sunghyun1999 commit message updated: