Remove Matrix and 400 error ignoring from chatCompletions #32948
Conversation
|
@microsoft-github-policy-service agree company="Microsoft" |
|
API change check API changes are not detected in this pull request. |
… mikhail/improvetests1
mikhail
requested review from
glharper,
deyaaeldeen and
minhanh-phan
as code owners
|
I queued a pipeline run in https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4635999&view=logs&j=43701d7e-216c-59bf-08d1-1efd0c7ac90a&t=837467d0-f383-5ba6-1b1a-21aa68346dfb and it seems that there're still a few cases that should be handled. For example:
|
|
My hunch is that these two errors should not be automatically ignored. If we expect the model to be supported and it isn't this is extremely important to become aware of. Similarly with 403 - If suddenly the live test key drops necessary permissions and all tests fire off 403 I don't want the tests to pass. Open to discussing this |
|
@mikhail Yeah I agree. There is a balance here between "are we testing the client" or "are we testing the service". I like the tests to be green as long as the client is doing its job but still I would like to get enough information in the test output to understand how the service behaves. |
|
@deyaaeldeen Agreed. I'd like to agree on some hard-defined rules on where that balance lies. If we're testing the client then let's create mock responses that include 4xx and 500 errors, and ensure that the client acts properly. If we have tests that hit the live service then it's no longer a unit/component/integration test, and shouldn't be treated as such. For example - I see zero value in, and on the contrary some danger in hitting an api that responds with Model Not Supported and then marking the test as Success, when that should be testing success of some model functionality |
I think there is a misunderstanding, the sensible thing to do here is not to use this particular model in this particular test. |
| ].includes(error.code) || | ||
| error.type === "invalid_request_error" || | ||
| error.name === "AbortError" || | ||
| errorStr.includes("Connection error") || | ||
| errorStr.includes("toolCalls") || | ||
| error.status === 404 | ||
| [ |
There was a problem hiding this comment.
nit: Would it make sense to put all these strings in an AcceptableErrors variable for this list similar to GlobalAcceptedErrors? Feel free to ignore this as we're moving away from this function.
| * @param clientsAndDeployments - | ||
| * @param run - | ||
| * @param validate - | ||
| * @param modelsListToSkip - | ||
| * @param acceptableErrors - |
There was a problem hiding this comment.
| * @param clientsAndDeployments - | |
| * @param run - | |
| * @param validate - | |
| * @param modelsListToSkip - | |
| * @param acceptableErrors - | |
| * @param clientsAndDeployments - Information about the clients and their associated deployments. | |
| * @param run - A function that runs the test on a given client and model. | |
| * @param validate - An optional function to validate the result of the run function. | |
| * @param modelsListToSkip - An optional list of models to skip during the test. | |
| * @param acceptableErrors - An optional list of acceptable errors that should not cause the test to fail. |
No description provided.