[ServiceBus] add message batch size limit #33300
Conversation
Even though Service Bus Premium namespaces support large messages up to 100 MB, batching of large messages is not supported. https://learn.microsoft.com/en-us/azure/service-bus-messaging/service-bus-premium-messaging#large-messages-support Currently we use the max message size as the max allowed batch size. This allows customers to add large messages into the batch only to get a cryptic "link **** is force detached" error from the service after sending the batch, as reported in Azure#33278 This PR updates `createBatch` to use two pre-defined maximum batch sizes, for Standard and Premium respectively, as the batch limits when creating batches, thus enforcing the proper limits on messages being added into the batch.
|
/azp run js - service-bus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
API change check API changes are not detected in this pull request. |
| if (maxMessageSize > maxBatchSizePremium) { | ||
| maxMessageSize = maxBatchSizePremium; | ||
| } else { | ||
| maxMessageSize = maxBatchSizeStandard; | ||
| } |
There was a problem hiding this comment.
Are we speculating here whether we're connected to a premium resource? Could this be done in a more robust way?
There was a problem hiding this comment.
The maxMessageSize is from the service. It is a good indicator since for standard it's 256 KB and for premium it is at least 1 MB.
There was a problem hiding this comment.
If the service introduces a new tier with a different batch size, would this code still work?
There was a problem hiding this comment.
we will need to update the code if that happens. Currently I am not aware of any way to retrieve the batch limit from the service. Let me ask the service team.
There was a problem hiding this comment.
We hope that existing libraries can continue to work. Does the service API use API versions to guard behavioral changes? If not, this code could be easily broken by a future change.
In general, yes we should avoid doing validation on client side. In this case the service is giving an error that is not helping customer. A better error would have been ideal. We can help customers here.
The batch size limits are constants according to the doc
|
Are these guaranteed to never change in the future? |
Great question! I will ask the service team and get back to this. |
|
Hi @jeremymeng. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
github-actions
bot
added
the
no-recent-activity
|
Hi @jeremymeng. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing |
Even though Service Bus Premium namespaces support large messages up to 100 MB, batching of large messages is
not supported.
https://learn.microsoft.com/en-us/azure/service-bus-messaging/service-bus-premium-messaging#large-messages-support
Currently we use the max message size as the max allowed batch size. This allows customers to add large
messages into the batch only to get a cryptic "link **** is force detached" error from the service after
sending the batch, as reported in
#33278
This PR updates
createBatchto use two pre-defined maximum batch sizes, for Standard and Premiumrespectively, as the batch limits when creating batches, thus enforcing the proper limits on messages being
added into the batch.
Packages impacted by this PR
@azure/service-busRelated PR
Azure/azure-sdk-for-python#38313