Test PR #33354
Open
Test PR #33354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujjwalsoni1707
requested review from
amanrao23,
aditishree1,
sajeetharan and
topshot99
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR re-enables the AbortController.signal validation test for the CosmosClient by removing the skip and adjusting the timing parameter in the abort trigger.
- Re-enabled the previously skipped test case to validate the abort signal behavior.
- Adjusted the delay value in setTimeout for aborting the request.
| it("should throw exception if aborted during the request", async function () { | ||
| const client = new CosmosClient({ endpoint, key: masterKey }); | ||
| try { | ||
| const controller = new AbortController(); | ||
| const signal = controller.signal; | ||
| setTimeout(() => controller.abort(), 1); | ||
| setTimeout(() => controller.abort(), 0.1); |
There was a problem hiding this comment.
Using a delay of 0.1 may be problematic since setTimeout expects an integer value in milliseconds; non-integer delays might be coerced to 0, potentially causing unintended behavior in the test. Consider reverting to an integer delay value, such as 1 ms, for reliable timing.
Suggested change
| setTimeout(() => controller.abort(), 0.1); | |
| setTimeout(() => controller.abort(), 1); |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
|
API change check API changes are not detected in this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/cosmos
Issues associated with this PR
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists