Added new communication identifier for OPS #33358
Draft
+598
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tifier Added support for a new communication identifier TeamsExtensionUserIdentifier with fields -userId -tenantId -resourceId Added new members to PhoneNumberIdentifier - isAnonymous -assertedId
…tifier - updated review Changes in generated file
AikoBB
reviewed
Mar 12, 2025
sdk/communication/communication-common/src/identifierModelSerializer.ts
Outdated
Show resolved
Hide resolved
sdk/communication/communication-common/src/identifierModelSerializer.ts
Outdated
Show resolved
Hide resolved
sdk/communication/communication-common/src/identifierModelSerializer.ts
Outdated
Show resolved
Hide resolved
Fixed after CommunicationIdentifierKind member renamed
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
Updated doc comments according to PR review comments
Added other teammembers of ACS Auth and Security team as codeowners of packages onwned by the team
Fixed prettier issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/communication-common
Issues associated with this PR
Describe the problem that is addressed by this PR
As a part of OnePhoneSystem feature, there were added new dual persona identities for Teams users that are using ACS to extend their Teams Phone setup. Ids of these dual personas look like the one used for CommunicationUserIdentifier, just it is structured to keep additional information about the Teams user.
To prevent necessity to parse CommunicationUserIdentifier id in every library to distinguish CommunicationUser and new Teams user dual persona, there has been new communication identifier TeamsExtensionUserIdentifier introduced.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
This PR just implement changes corresponding to rest API changes from 2025-03-15-preview
Azure/azure-rest-api-specs#32704
Are there test cases added in this PR? (If not, why?)
Yes
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists