[EngSys] unpin typescript version #33362
Open
+5,510
−6,169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- dev-tool: work around codemods ts-morph incompatibility ***NO_CI***
now that api-extractor bundles v5.8.2 also need to pin vitest to 3.0.7 because 3.0.8 broke installation and we need the following fix to be published vitest-dev/vitest#7628 - rush update --full
jeremymeng
requested review from
ckairen,
a team,
mikeharder and
deyaaeldeen
as code owners
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
use `Buffer.isBuffer()` to narrow the type. `instanceof` no longer works in v5.8.2
jeremymeng
requested review from
EmmaZhu,
XiaoningLiu,
vinjiang,
jiacfan,
ljian3377 and
blueww
as code owners
deyaaeldeen
approved these changes
Mar 12, 2025
|
API change check API changes are not detected in this pull request. |
also fix helper in ai-translation-document-rest
jeremymeng
requested review from
weshaggard,
benbp,
mpodwysocki,
timovv and
qiaozha
as code owners
jeremymeng
requested review from
shwali-msft,
allchiang-msft,
arifibrahim4,
juancamilor,
glorialimicrosoft,
Shamkh,
marche0133,
yogeshmo,
natekimball-msft,
kagbakpem,
LuChen-Microsoft,
minwoolee-msft,
juntuchen-msft,
khannavikas,
akania,
wiboris,
wanghoppe,
dpwatrous,
cRui861,
skapur12,
LarryOsterman,
anilba06 and
gkostal
as code owners
jeremymeng
requested review from
joshfree,
pvaneck,
KevinBlasko,
scottaddie,
jairmyree,
nisha-bhatia and
Haiying-MSFT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now that api-extractor bundles v5.8.2
also need to pin vitest to 3.0.7 because 3.0.8 broke installation and we need
the following fix to be published
vitest-dev/vitest#7628
rush update --full
fix typing issue in some storage samples