-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[core-lro] Support path rewriting #33363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d3a3440
[core-lro] Support path rewriting
deyaaeldeen 2661c8e
update version
deyaaeldeen fec5707
Update sdk/core/core-lro/src/http/utils.ts
deyaaeldeen 76544ae
fix format
deyaaeldeen 3cfd251
Merge remote-tracking branch 'origin/main' into core-lro-base-url
deyaaeldeen 1f2282c
address feedback
deyaaeldeen a5a1481
address Jeff's feedback
deyaaeldeen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
// Copyright (c) Microsoft Corporation. | ||
// Licensed under the MIT License. | ||
|
||
/** | ||
* Rewrites a given URL to use the specified base URL. | ||
* It preserves the pathname, search parameters, and fragment. | ||
* Handles relative URLs and proper encoding. | ||
* | ||
* @param params - An object containing the url and baseUrl. | ||
* url - The original URL (absolute or relative). | ||
* baseUrl - The new base URL to use. | ||
* @returns The rewritten URL as a string. | ||
*/ | ||
export function rewriteUrl({ | ||
url, | ||
baseUrl, | ||
}: { | ||
url?: string; | ||
baseUrl?: string; | ||
}): string | undefined { | ||
if (!url) { | ||
return undefined; | ||
} | ||
if (!baseUrl) { | ||
return url; | ||
} | ||
|
||
let originalUrl: URL; | ||
|
||
try { | ||
// Try to parse inputUrl as an absolute URL. | ||
originalUrl = new URL(url); | ||
} catch { | ||
// If inputUrl is relative, resolve using the provided baseUrl. | ||
try { | ||
originalUrl = new URL(url, baseUrl); | ||
deyaaeldeen marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} catch (e) { | ||
throw new Error(`Invalid input URL provided: ${url}`); | ||
} | ||
} | ||
|
||
deyaaeldeen marked this conversation as resolved.
Show resolved
Hide resolved
|
||
let newBase: URL; | ||
try { | ||
newBase = new URL(baseUrl); | ||
} catch (e) { | ||
throw new Error(`Invalid base URL provided: ${baseUrl}`); | ||
} | ||
|
||
const rewrittenUrl = new URL( | ||
`${originalUrl.pathname}${originalUrl.search}${originalUrl.hash}`, | ||
jeremymeng marked this conversation as resolved.
Show resolved
Hide resolved
|
||
newBase, | ||
); | ||
|
||
return rewrittenUrl.toString(); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.