[EngSys] Add dev tool check to analyze step
#36824
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgetu
requested review from
a team,
JacksonWeber,
KarishmaGhiya,
MSNev,
MaryGao,
andykao1213,
axisc,
benbp,
dargilco,
dubiety,
hectorhdzg,
hmlam,
jeremydvoss,
jeremymeng,
lzchen,
mikeharder,
qiaozha,
rads-1996,
rhurey,
sjkwak,
srnagar,
weshaggard and
xitzhang
as code owners
github-actions
bot
added
Mgmt
github-actions
bot
added
Synapse
Tables
test-utils
github-project-automation
bot
added this to
Azure SDK for Key Vault and Azure Identity SDK Improvements
github-project-automation
bot
moved this to Untriaged
in Azure Identity SDK Improvements
dgetu
force-pushed
the
add-dev-tool-check-to-analyze-step
branch
from
9658e20 to
5c6ee6c
Compare
Member
|
Look great and nice to see bugs were fixed! We need to update our code generator first. It would be nice if we can undo the package.json formatting changes to make PR review easier. |
jeremymeng
reviewed
Dec 8, 2025
| }, | ||
| "autoPublish": true, | ||
| "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/advisor/arm-advisor", | ||
| "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/advisor/arm-advisor/README.md", |
Member
There was a problem hiding this comment.
We either need to standardize on the homepage format, or relax dev-tool to allow the format that Management packages use. Standardizing is probably better.
| "build": "npm run clean && dev-tool run build-package && dev-tool run extract-api", | ||
| "build:samples": "tsc -p tsconfig.samples.json && dev-tool samples publish -f", | ||
| "check-format": "prettier --list-different --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.ts\" \"samples-dev/**/*.ts\" \"test/**/*.ts\" \"*.{js,json}\"", | ||
| "check:ci": "dev-tool check --tag ci", |
Member
There was a problem hiding this comment.
We need a corresponding code generator PR to add the two check NPM scripts
Member
There was a problem hiding this comment.
Yes and pls don't forget to apply this in codegen repo. Thanks!
| node eng/tools/ci-runner/index.js check-format $(ChangedServices) -packages "$(ArtifactPackageNames)" | ||
| displayName: "Check Format in Libraries" | ||
| node eng/tools/ci-runner/index.js check:ci $(ChangedServices) -packages "$(ArtifactPackageNames)" | ||
| displayName: "Check Libraries" |
Member
There was a problem hiding this comment.
is there a condition in pipeline build that we can check for whether we should run check:release?
| "engines": { | ||
| "node": ">=20.0.0" | ||
| }, | ||
| "engines": { "node": ">=20.0.0" }, |
Member
There was a problem hiding this comment.
Why was Mgmt package.json formatted? it's "format" script just echo.
| import type { CommunicationIdentifier } from "@azure/communication-common"; | ||
|
|
||
| import type { | ||
| Tone} from "../generated/src/models/index.js"; |
Member
There was a problem hiding this comment.
formatting here doesn't look right.
| "vitest": "catalog:testing" | ||
| }, | ||
| "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/communication/communication-messages-rest-rest/README.md", | ||
| "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/communication/communication-messages-rest/README.md", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
#36589
Describe the problem that is addressed by this PR
Replaces format and lint steps with
dev-tool checkChecklists
***NO_CI***