Skip to content

Conversation

@azure-sdk
Copy link
Collaborator

Configurations: 'specification/vmware/resource-manager/Microsoft.AVS/AVS/tspconfig.yaml', API Version: 2025-09-01, SDK Release Type: stable, and CommitSHA: 'c920bd9f5b44dd03ea3e195ac3ae0d4a79f7601f' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5688241 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.

…AVS/tspconfig.yaml', API Version: 2025-09-01, SDK Release Type: stable, and CommitSHA: 'c920bd9f5b44dd03ea3e195ac3ae0d4a79f7601f' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5688241 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Dec 19, 2025
@github-actions
Copy link

github-actions bot commented Dec 19, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

@azure/arm-avs

Copy link
Member

@cataggar cataggar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better. No breaking changes.

@cataggar cataggar marked this pull request as ready for review December 19, 2025 17:10
@cataggar cataggar requested a review from qiaozha as a code owner December 19, 2025 17:10
Copilot AI review requested due to automatic review settings December 19, 2025 17:10
@cataggar cataggar requested a review from MaryGao as a code owner December 19, 2025 17:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Azure VMware Solution SDK from API version 2024-09-01 to 2025-09-01. The changes include updating API version references in sample files, dependency version updates, documentation formatting improvements, and new sample files for newly added API endpoints (Licenses and Maintenances resources).

Key Changes:

  • Updated API version from 2024-09-01 to 2025-09-01 across all sample files
  • Added new sample files for Licenses and Maintenances resources
  • Updated dependencies (@azure/identity and TypeScript versions)
  • Code formatting improvements (condensed multi-line object literals to single lines)

Reviewed changes

Copilot reviewed 300 out of 490 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sdk/avs/arm-avs/samples/v7/typescript/package.json Updated @azure/identity to ^4.13.0, TypeScript to ~5.9.3, added cross-env dependency
sdk/avs/arm-avs/samples/v7/javascript/package.json Updated @azure/identity to ^4.13.0, added cross-env as devDependency
sdk/avs/arm-avs/samples/v7/typescript/README.md Updated API version references and added new Licenses/Maintenances sample entries
sdk/avs/arm-avs/samples/v7/javascript/README.md Updated API version references and added new Licenses/Maintenances sample entries
All sample .ts/.js files Updated x-ms-original-file comments from 2024-09-01 to 2025-09-01, reformatted code for consistency
New Licenses sample files Added samples for new Licenses resource operations
New Maintenances sample files Added samples for new Maintenances resource operations
privateCloudsCreateOrUpdateSample files Added vcfLicense property to sample data
privateCloudsGetVcfLicenseSample files New sample for retrieving VCF license information
operationsListSample.js Fixed subscription ID typo (missing final '0')
maintenancesRescheduleSample.js Contains a date in the past (2023-01-12) in sample data

@kazrael2119 kazrael2119 added the Self-Service Release PR for self-service release label Dec 23, 2025
@kazrael2119
Copy link
Member

LGTM
cc @qiaozha

@@ -98,7 +98,7 @@ describe("avs test", () => {
assert.equal(resArray.length, 1); // should be 1,but when testing this test there's 2 resources on portal
});

it("operation list test", async () => {
it.skip("operation list test", async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we skip this test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management-plane library. Self-Service Release PR for self-service release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants