Sync eng/common directory with azure-sdk-tools for PR 14420#37620
Closed
Sync eng/common directory with azure-sdk-tools for PR 14420#37620
Conversation
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new shared Azure Pipelines job template intended to run azsdk-cli benchmark scenarios via dotnet run, with parameters for scenario selection, tagging, model override, and parallelism.
Changes:
- Introduces
benchmark-job.ymljob template with configurable benchmark project/scenario inputs. - Uses
sparse-checkout.ymlto fetch only the needed repo paths before executing benchmarks. - Runs the benchmark harness with a computed CLI argument list (scenario name vs tags vs
--all).
| - '${{ parameters.BenchmarkProject }}/**' | ||
| - 'eng/common/**' | ||
|
|
||
| - template: /eng/pipelines/templates/steps/install-dotnet.yml |
There was a problem hiding this comment.
The template references /eng/pipelines/templates/steps/install-dotnet.yml, but that file does not exist in this repo (there is no eng/pipelines/templates/steps/install-dotnet.yml in eng/pipelines/templates/steps/). This will break the job at template-expansion time. Consider inlining the UseDotNet@2 tasks (as done in eng/common/pipelines/templates/jobs/ai-eval-job.yml) or referencing an existing shared template path.
Suggested change
| - template: /eng/pipelines/templates/steps/install-dotnet.yml | |
| - task: UseDotNet@2 | |
| displayName: 'Install .NET SDK' | |
| inputs: | |
| packageType: 'sdk' | |
| useGlobalJson: true |
azure-sdk
force-pushed
the
sync-eng/common-azsdk-benchmark-pipeline-14420
branch
from
6727269 to
3b4b124
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#14420 See eng/common workflow