Skip to content

[AutoPR @azure-contoso-widgetmanager]-generated-from-SDK Generation - JS-6050090#37783

Closed
azure-sdk wants to merge 1 commit into
mainfrom
sdkauto/@azure-contoso-widgetmanager-6050090
Closed

[AutoPR @azure-contoso-widgetmanager]-generated-from-SDK Generation - JS-6050090#37783
azure-sdk wants to merge 1 commit into
mainfrom
sdkauto/@azure-contoso-widgetmanager-6050090

Conversation

@azure-sdk

Copy link
Copy Markdown
Collaborator

Configurations: 'specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml', API Version: 2026-03-01-preview, SDK Release Type: beta, and CommitSHA: 'eabb54a20ec2e6214f756d805261dfc3312ebea8' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6050090 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.

…ager/tspconfig.yaml', API Version: 2026-03-01-preview, SDK Release Type: beta, and CommitSHA: 'eabb54a20ec2e6214f756d805261dfc3312ebea8' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6050090 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
@github-actions github-actions Bot added the Mgmt This issue is related to a management-plane library. label Mar 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

API Change Check

APIView identified API level changes in this PR and created the following API reviews

@azure/contoso-widgetmanager

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 tool issue found. The new @azure/contoso-widgetmanager package (v1.0.0-beta.1) has a clean public API surface — no naming violations, no unsafe unknown return types, no problematic void on get/list/create/update operations, and the version string in widgetManagerContext.ts correctly matches package.json. The only finding is a missing CHANGELOG.md, which the generation tool should have produced for the initial release.

📊 Structured Report
{"agent":"mgmt-reviewer","pr":37783,"summary":"issues_found","findings":[{"file":"sdk/contosowidgetmanager/contoso-widgetmanager/package.json","line":3,"issueType":"tool","category":"missing-file","description":"CHANGELOG.md is absent from the new package; the generation tool should produce a hard-coded initial-release changelog entry."}]}

Benchmarked by Management SDK PR Review

@@ -0,0 +1,169 @@
{
"name": "@azure/contoso-widgetmanager",
"version": "1.0.0-beta.1",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Tool Issuepackage.json:3 (missing CHANGELOG.md)

The package is missing a CHANGELOG.md file. All Azure SDK packages — including initial releases — must ship with a changelog. Sibling packages (e.g., @azure/arm-appnetwork, @azure/arm-applink) all include a CHANGELOG.md generated alongside the first 1.0.0-beta.1 entry.

Fix: Regenerate the package so the tool produces a CHANGELOG.md with the hard-coded first-release entry (e.g. ## 1.0.0-beta.1 (YYYY-MM-DD)\n\n### Features Added\n\n- Initial release.). If the tool consistently omits CHANGELOG.md, report the issue in the generation tool repository.

@github-actions

Copy link
Copy Markdown
Contributor

Hi @azure-sdk. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions Bot added the no-recent-activity There has been no recent activity on this issue. label May 29, 2026
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Hi @azure-sdk. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

@github-actions github-actions Bot closed this Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management-plane library. mgmt-review-needed no-recent-activity There has been no recent activity on this issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants