Skip to content

Sync eng/common directory with azure-sdk-tools for PR 14709#37838

Merged
benbp merged 4 commits into
mainfrom
sync-eng/common-benbp/azsdk-install-perf-14709
Mar 25, 2026
Merged

Sync eng/common directory with azure-sdk-tools for PR 14709#37838
benbp merged 4 commits into
mainfrom
sync-eng/common-benbp/azsdk-install-perf-14709

Conversation

@azure-sdk
Copy link
Copy Markdown
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#14709 See eng/common workflow

@azure-sdk azure-sdk requested a review from a team as a code owner March 25, 2026 21:45
@azure-sdk azure-sdk requested review from benbp and Copilot March 25, 2026 21:45
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Mar 25, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR syncs the eng/common MCP installer script with the corresponding changes from azure-sdk-tools PR 14709, updating how the azsdk CLI/MCP server is installed and invoked.

Changes:

  • Removes configurable FileName/Package parameters and hardcodes azsdk / Azure.Sdk.Tools.Cli values.
  • Adds a fast-path to detect an existing azsdk install and skip reinstall if the requested/latest version is already present.
  • Adjusts process invocation to run the azsdk mcp command and propagates the child process exit code.
Comments suppressed due to low confidence (1)

eng/common/mcp/azure-sdk-mcp.ps1:156

  • In the non-MCP branch, the final line of the Install-Standalone-Tool invocation ends with a backtick line-continuation (after -Repository $Repository). That makes the command continue onto the next line (}), which will cause a parse/syntax error when running the script. Remove the trailing backtick (or add the intended continuation) so the call terminates correctly.
    $tempExe = Install-Standalone-Tool `
        -Version $Version `
        -FileName $packageFileName `
        -Package $packageName `
        -Directory $tempInstallDirectory `
        -Repository $Repository `

}

Comment thread eng/common/mcp/azure-sdk-mcp.ps1
@benbp benbp merged commit ae7cf5f into main Mar 25, 2026
100 of 120 checks passed
@benbp benbp deleted the sync-eng/common-benbp/azsdk-install-perf-14709 branch March 25, 2026 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants