Sync eng/common directory with azure-sdk-tools for PR 14709#37838
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR syncs the eng/common MCP installer script with the corresponding changes from azure-sdk-tools PR 14709, updating how the azsdk CLI/MCP server is installed and invoked.
Changes:
- Removes configurable
FileName/Packageparameters and hardcodesazsdk/Azure.Sdk.Tools.Clivalues. - Adds a fast-path to detect an existing
azsdkinstall and skip reinstall if the requested/latest version is already present. - Adjusts process invocation to run the
azsdk mcpcommand and propagates the child process exit code.
Comments suppressed due to low confidence (1)
eng/common/mcp/azure-sdk-mcp.ps1:156
- In the non-MCP branch, the final line of the
Install-Standalone-Toolinvocation ends with a backtick line-continuation (after-Repository $Repository). That makes the command continue onto the next line (}), which will cause a parse/syntax error when running the script. Remove the trailing backtick (or add the intended continuation) so the call terminates correctly.
$tempExe = Install-Standalone-Tool `
-Version $Version `
-FileName $packageFileName `
-Package $packageName `
-Directory $tempInstallDirectory `
-Repository $Repository `
}
benbp
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#14709 See eng/common workflow