Skip to content

[AutoPR @azure-arm-networkcloud]-generated-from-SDK Generation - JS-6259530#38443

Open
azure-sdk wants to merge 3 commits into
mainfrom
sdkauto/@azure-arm-networkcloud-6259530
Open

[AutoPR @azure-arm-networkcloud]-generated-from-SDK Generation - JS-6259530#38443
azure-sdk wants to merge 3 commits into
mainfrom
sdkauto/@azure-arm-networkcloud-6259530

Conversation

@azure-sdk

@azure-sdk azure-sdk commented May 6, 2026

Copy link
Copy Markdown
Collaborator

Configurations: 'specification/networkcloud/NetworkCloud.Management/tspconfig.yaml', API Version: 2026-05-01-preview, SDK Release Type: beta, and CommitSHA: '13d51ee484703ea6845668fbf4b9de13f41bf5c2' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6259530 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releasePlan=2218 Submitted by: nafizhaider@microsoft.com

Release Plan Details

…spconfig.yaml', API Version: 2026-05-01-preview, SDK Release Type: beta, and CommitSHA: '13d51ee484703ea6845668fbf4b9de13f41bf5c2' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6259530 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
…spconfig.yaml', API Version: 2026-05-01-preview, SDK Release Type: beta, and CommitSHA: '13c2dbb75b6428e8a8e0751e40fe1e3dbc453d8b' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6259617 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
@kazrael2119 kazrael2119 marked this pull request as ready for review May 7, 2026 02:27
Copilot AI review requested due to automatic review settings May 7, 2026 02:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@github-actions github-actions Bot added mgmt-review-in-progress Management SDK review is in progress and removed mgmt-review-needed labels May 7, 2026
@kazrael2119 kazrael2119 added the first-typespec-migration first time to migrate to typespec label May 7, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 tool issue found: The CHANGELOG.md compares 2.0.0-beta.2 against 1.3.0 instead of the previously published 2.0.0-beta.1. The public API surface in the review files looks otherwise correct — client name NetworkCloudClient is appropriate, KnownVersions enum contains the expected API versions (2025-09-01, 2026-01-01-preview, 2026-05-01-preview), and client options extend ClientOptions as expected.

📊 Structured Report
{"agent":"mgmt-reviewer","pr":38443,"summary":"issues_found","findings":[{"file":"sdk/networkcloud/arm-networkcloud/CHANGELOG.md","line":4,"issueType":"tool","category":"changelog-comparison-version","description":"CHANGELOG for 2.0.0-beta.2 compares against 1.3.0 instead of the previously published 2.0.0-beta.1"}]}

Benchmarked by Management Release Assistant

Comment thread sdk/networkcloud/arm-networkcloud/CHANGELOG.md
…spconfig.yaml', API Version: 2026-05-01-preview, SDK Release Type: beta, and CommitSHA: '67b16bc7569e42c4ac751d7291a5dd79e0682de0' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6262582 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
@kazrael2119 kazrael2119 added mgmt-review-needed and removed mgmt-review-in-progress Management SDK review is in progress labels May 7, 2026
@github-actions github-actions Bot added mgmt-review-in-progress Management SDK review is in progress and removed mgmt-review-needed labels May 7, 2026
@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

Next Steps to Merge

Only failed checks and required actions are listed below.

  • UnitTest (node/browser): Stale test recordings — tests request api-version=2026-05-01-preview but recordings were made with an older API version (RecorderError: Unable to find a record for the request GET .../operations?api-version=2026-05-01-preview). Action: Re-record tests following the test recording guide, or request maintainer approval to skip tests with .skip. Review ADO logs.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 tool issue found in @azure/arm-networkcloud (v2.0.0-beta.2): The CHANGELOG compares against 1.3.0 instead of the previously published 2.0.0-beta.1, indicating a tooling bug.

📊 Structured Report
{"agent":"mgmt-reviewer","pr":38443,"summary":"issues_found","findings":[{"file":"sdk/networkcloud/arm-networkcloud/CHANGELOG.md","line":4,"issueType":"tool","category":"changelog-baseline","description":"CHANGELOG for 2.0.0-beta.2 compares against 1.3.0 instead of the previously published 2.0.0-beta.1"}]}

Benchmarked by Management Release Assistant

Comment thread sdk/networkcloud/arm-networkcloud/CHANGELOG.md
@kazrael2119

This comment was marked as off-topic.

@kazrael2119

Copy link
Copy Markdown
Member

Next Steps to Merge

Only failed checks and required actions are listed below.

  • UnitTest (node/browser): Stale test recordings — tests request api-version=2026-05-01-preview but recordings were made with an older API version (RecorderError: Unable to find a record for the request GET .../operations?api-version=2026-05-01-preview). Action: Re-record tests following the test recording guide, or request maintainer approval to skip tests with .skip. Review ADO logs.

please follow this guide to fix ci failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

first-typespec-migration first time to migrate to typespec Mgmt This issue is related to a management-plane library. mgmt-review-in-progress Management SDK review is in progress Self-Service Release PR for self-service release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants