[notification-hubs] fix samples build#38784
Open
jeremymeng wants to merge 1 commit into
Open
Conversation
update type-only imports and publish samples
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Notification Hubs v2 samples to build cleanly by modernizing the TypeScript sample tsconfig, converting several imports to import type, fixing an incorrect await on Array#push, and republishing the generated samples/ outputs and READMEs.
Changes:
- Update TypeScript samples configuration (NodeNext module/resolution, Node types, rootDir/lib) to align with current TS/Node expectations.
- Convert type-only imports across TypeScript samples (and
samples-dev) to avoid runtime import issues. - Fix sample logic/docs issues (remove
awaitfrompush, and update README to usenpx cross-envwith added dependency).
Reviewed changes
Copilot reviewed 38 out of 38 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/notificationhubs/notification-hubs/samples/v2/typescript/tsconfig.json | Update TS compiler settings to NodeNext + add libs/types/rootDir for successful compilation. |
| sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/updateRegistration.ts | Remove incorrect await on Array#push. |
| sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/updateInstallation.ts | Convert JsonPatch import to type-only. |
| sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/sendTagsList.ts | Convert several model/context imports to type-only. |
| sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/sendTagExpression.ts | Convert several model/context imports to type-only. |
| sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/sendDirectNotificationBatch.ts | Convert several model/context imports to type-only. |
| sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/sendDirectNotification.ts | Convert several model/context imports to type-only. |
| sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/sendDirectNotification.fcmV1.ts | Convert several model/context imports to type-only. |
| sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/sendDirectNotification.fcmLegacy.ts | Convert several model/context imports to type-only. |
| sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/sendBroadcastNotification.ts | Convert model/context imports to type-only. |
| sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/listRegistrationsByChannel.ts | Convert AppleRegistrationChannel import to type-only. |
| sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/importRegistrationsJob.ts | Convert NotificationHubJob import to type-only. |
| sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/importRegistrationsJob.poller.ts | Import poller type and adjust poller assignment (currently via cast). |
| sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/exportRegistrationsJob.ts | Convert NotificationHubJob import to type-only. |
| sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/exportRegistrationsJob.polling.ts | Import poller type and adjust poller assignment (currently via cast). |
| sdk/notificationhubs/notification-hubs/samples/v2/typescript/src/createInstallation.fcmV1.ts | Whitespace cleanup in header. |
| sdk/notificationhubs/notification-hubs/samples/v2/typescript/README.md | Update guidance to use npx cross-env and clarify wording. |
| sdk/notificationhubs/notification-hubs/samples/v2/typescript/package.json | Add cross-env devDependency and bump TS version for sample build. |
| sdk/notificationhubs/notification-hubs/samples/v2/javascript/updateRegistration.js | Remove incorrect await on Array#push. |
| sdk/notificationhubs/notification-hubs/samples/v2/javascript/updateInstallation.js | Remove extraneous blank line. |
| sdk/notificationhubs/notification-hubs/samples/v2/javascript/README.md | Update guidance to use npx cross-env and clarify wording. |
| sdk/notificationhubs/notification-hubs/samples/v2/javascript/package.json | Add cross-env devDependency for README command. |
| sdk/notificationhubs/notification-hubs/samples/v2/javascript/listRegistrationsByChannel.js | Remove extraneous blank line. |
| sdk/notificationhubs/notification-hubs/samples/v2/javascript/importRegistrationsJob.poller.js | Remove extraneous blank line. |
| sdk/notificationhubs/notification-hubs/samples/v2/javascript/importRegistrationsJob.js | Whitespace cleanup in header. |
| sdk/notificationhubs/notification-hubs/samples/v2/javascript/exportRegistrationsJob.polling.js | Remove extraneous blank line. |
| sdk/notificationhubs/notification-hubs/samples/v2/javascript/createInstallation.fcmV1.js | Whitespace cleanup in header. |
| sdk/notificationhubs/notification-hubs/samples-dev/updateInstallation.ts | Convert JsonPatch import to type-only. |
| sdk/notificationhubs/notification-hubs/samples-dev/sendTagsList.ts | Convert several model/context imports to type-only. |
| sdk/notificationhubs/notification-hubs/samples-dev/sendTagExpression.ts | Convert several model/context imports to type-only. |
| sdk/notificationhubs/notification-hubs/samples-dev/sendDirectNotificationBatch.ts | Convert several model/context imports to type-only. |
| sdk/notificationhubs/notification-hubs/samples-dev/sendDirectNotification.ts | Convert several model/context imports to type-only. |
| sdk/notificationhubs/notification-hubs/samples-dev/sendDirectNotification.fcmV1.ts | Convert several model/context imports to type-only. |
| sdk/notificationhubs/notification-hubs/samples-dev/sendDirectNotification.fcmLegacy.ts | Convert several model/context imports to type-only. |
| sdk/notificationhubs/notification-hubs/samples-dev/sendBroadcastNotification.ts | Convert model/context imports to type-only. |
| sdk/notificationhubs/notification-hubs/samples-dev/listRegistrationsByChannel.ts | Convert AppleRegistrationChannel import to type-only. |
| sdk/notificationhubs/notification-hubs/samples-dev/importRegistrationsJob.ts | Convert NotificationHubJob import to type-only. |
| sdk/notificationhubs/notification-hubs/samples-dev/exportRegistrationsJob.ts | Convert NotificationHubJob import to type-only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update type-only imports and publish samples