[AutoPR @azure-arm-hanaonazure]-generated-from-SDK Generation - JS-6398432#38836
Conversation
….HanaOnAzure/HanaOnAzure/tspconfig.yaml', API Version: 2020-02-07-preview, SDK Release Type: beta, and CommitSHA: '4375d0c4eb36e73152199e484c0d4537ddd4c9da' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6398432 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
There was a problem hiding this comment.
Pull request overview
This AutoPR updates @azure/arm-hanaonazure to the latest management SDK generation output (TypeSpec-based, Track 2 “layered” API style), refreshing the client surface, static helpers (paging/LRO/url templates), and regenerating samples/metadata for the 2020-02-07-preview API (beta release line).
Changes:
- Regenerates the HanaOnAzure management client to the layered
api/+classic/structure and updates package exports accordingly. - Adds shared static helpers for paging and LRO polling (plus poller restore support) and updates public exports.
- Refreshes samples, build/test configs, and repo metadata (CODEOWNERS, pipeline config, assets tag, tsp-location).
Reviewed changes
Copilot reviewed 99 out of 101 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/hanaonazure/ci.mgmt.yml | CI trigger update for the HanaOnAzure service folder. |
| sdk/hanaonazure/arm-hanaonazure/warp.config.yml | Warp build/export configuration for the regenerated package. |
| sdk/hanaonazure/arm-hanaonazure/tsp-location.yaml | Records the TypeSpec source location/commit for regeneration provenance. |
| sdk/hanaonazure/arm-hanaonazure/tsconfig.json | TS project references adjusted (incl. browser test project). |
| sdk/hanaonazure/arm-hanaonazure/test/snippets.spec.ts | Browser snippet ordering tweak for sample client creation. |
| sdk/hanaonazure/arm-hanaonazure/src/static-helpers/urlTemplate.ts | Adds RFC6570 URL template expansion helper used by generated operations. |
| sdk/hanaonazure/arm-hanaonazure/src/static-helpers/simplePollerHelpers.ts | Adds legacy/simple poller facade over @azure/core-lro pollers. |
| sdk/hanaonazure/arm-hanaonazure/src/static-helpers/serialization/check-prop-undefined.ts | Adds helper to check undefined properties during serialization. |
| sdk/hanaonazure/arm-hanaonazure/src/static-helpers/pollingHelpers.ts | Adds helper to create LRO pollers for REST-layer operations. |
| sdk/hanaonazure/arm-hanaonazure/src/static-helpers/pagingHelpers.ts | Adds helper to build paged async iterators for list operations. |
| sdk/hanaonazure/arm-hanaonazure/src/static-helpers/cloudSettingHelpers.ts | Adds cloud setting enum + ARM endpoint resolution helper. |
| sdk/hanaonazure/arm-hanaonazure/src/restorePollerHelpers.ts | Adds restore-from-serialized-state poller support. |
| sdk/hanaonazure/arm-hanaonazure/src/pagingHelper.ts | Removes legacy continuation-token helper (replaced by new paging helpers). |
| sdk/hanaonazure/arm-hanaonazure/src/operationsInterfaces/sapMonitors.ts | Removes legacy operation interface (replaced by layered classic/api). |
| sdk/hanaonazure/arm-hanaonazure/src/operationsInterfaces/providerInstances.ts | Removes legacy operation interface (replaced by layered classic/api). |
| sdk/hanaonazure/arm-hanaonazure/src/operationsInterfaces/operations.ts | Removes legacy operation interface (replaced by layered classic/api). |
| sdk/hanaonazure/arm-hanaonazure/src/operationsInterfaces/index.ts | Removes legacy operation interface barrel export. |
| sdk/hanaonazure/arm-hanaonazure/src/operations/operations.ts | Removes legacy operation implementations. |
| sdk/hanaonazure/arm-hanaonazure/src/operations/index.ts | Removes legacy operations barrel export. |
| sdk/hanaonazure/arm-hanaonazure/src/models/parameters.ts | Removes legacy core-client parameter definitions. |
| sdk/hanaonazure/arm-hanaonazure/src/models/mappers.ts | Removes legacy core-client mappers. |
| sdk/hanaonazure/arm-hanaonazure/src/models/index.ts | Switches models export surface to new models.js-based definitions. |
| sdk/hanaonazure/arm-hanaonazure/src/lroImpl.ts | Removes legacy custom LRO implementation. |
| sdk/hanaonazure/arm-hanaonazure/src/logger.ts | Adds package logger via @azure/logger. |
| sdk/hanaonazure/arm-hanaonazure/src/index.ts | Updates public exports for layered API, helpers, and core errors. |
| sdk/hanaonazure/arm-hanaonazure/src/hanaManagementClient.ts | Replaces legacy ServiceClient-based client with layered REST client wrapper. |
| sdk/hanaonazure/arm-hanaonazure/src/classic/sapMonitors/index.ts | Adds “classic” operation group wrapper over REST operations (SapMonitors). |
| sdk/hanaonazure/arm-hanaonazure/src/classic/providerInstances/index.ts | Adds “classic” operation group wrapper over REST operations (ProviderInstances). |
| sdk/hanaonazure/arm-hanaonazure/src/classic/operations/index.ts | Adds “classic” operation group wrapper over REST operations (Operations). |
| sdk/hanaonazure/arm-hanaonazure/src/classic/index.ts | Adds classic operation-group type barrel. |
| sdk/hanaonazure/arm-hanaonazure/src/api/sapMonitors/options.ts | Adds options-bag types for SapMonitors REST operations. |
| sdk/hanaonazure/arm-hanaonazure/src/api/sapMonitors/operations.ts | Adds SapMonitors REST operations (send/deserialize + convenience methods). |
| sdk/hanaonazure/arm-hanaonazure/src/api/sapMonitors/index.ts | Adds SapMonitors REST barrel exports. |
| sdk/hanaonazure/arm-hanaonazure/src/api/providerInstances/options.ts | Adds options-bag types for ProviderInstances REST operations. |
| sdk/hanaonazure/arm-hanaonazure/src/api/providerInstances/operations.ts | Adds ProviderInstances REST operations. |
| sdk/hanaonazure/arm-hanaonazure/src/api/providerInstances/index.ts | Adds ProviderInstances REST barrel exports. |
| sdk/hanaonazure/arm-hanaonazure/src/api/operations/options.ts | Adds options-bag types for Operations REST operations. |
| sdk/hanaonazure/arm-hanaonazure/src/api/operations/operations.ts | Adds Operations REST list operation (paged). |
| sdk/hanaonazure/arm-hanaonazure/src/api/operations/index.ts | Adds Operations REST barrel exports. |
| sdk/hanaonazure/arm-hanaonazure/src/api/index.ts | Adds top-level api/ barrel exports. |
| sdk/hanaonazure/arm-hanaonazure/src/api/hanaManagementContext.ts | Adds REST client context creation and client options definitions. |
| sdk/hanaonazure/arm-hanaonazure/samples/v4-beta/typescript/tsconfig.json | Updates sample TS compilation target/module settings. |
| sdk/hanaonazure/arm-hanaonazure/samples/v4-beta/typescript/src/sapMonitorsUpdateSample.ts | Updates generated TypeScript sample for new client API surface. |
| sdk/hanaonazure/arm-hanaonazure/samples/v4-beta/typescript/src/sapMonitorsListSample.ts | Updates generated TypeScript list sample for new client API surface. |
| sdk/hanaonazure/arm-hanaonazure/samples/v4-beta/typescript/src/sapMonitorsGetSample.ts | Updates generated TypeScript get sample for new client API surface. |
| sdk/hanaonazure/arm-hanaonazure/samples/v4-beta/typescript/src/sapMonitorsDeleteSample.ts | Updates generated TypeScript delete sample for new client API surface. |
| sdk/hanaonazure/arm-hanaonazure/samples/v4-beta/typescript/src/sapMonitorsCreateSample.ts | Updates generated TypeScript create sample for new client API surface. |
| sdk/hanaonazure/arm-hanaonazure/samples/v4-beta/typescript/src/providerInstancesListSample.ts | Updates generated TypeScript providerInstances list sample. |
| sdk/hanaonazure/arm-hanaonazure/samples/v4-beta/typescript/src/providerInstancesGetSample.ts | Updates generated TypeScript providerInstances get sample. |
| sdk/hanaonazure/arm-hanaonazure/samples/v4-beta/typescript/src/providerInstancesDeleteSample.ts | Updates generated TypeScript providerInstances delete sample. |
| sdk/hanaonazure/arm-hanaonazure/samples/v4-beta/typescript/src/providerInstancesCreateSample.ts | Updates generated TypeScript providerInstances create sample. |
| sdk/hanaonazure/arm-hanaonazure/samples/v4-beta/typescript/src/operationsListSample.ts | Updates generated TypeScript operations list sample. |
| sdk/hanaonazure/arm-hanaonazure/samples/v4-beta/typescript/sample.env | Simplifies sample env template. |
| sdk/hanaonazure/arm-hanaonazure/samples/v4-beta/typescript/README.md | Updates sample README to new package naming/paths and regenerated descriptions. |
| sdk/hanaonazure/arm-hanaonazure/samples/v4-beta/typescript/package.json | Updates sample package dependencies/devDependencies for beta line. |
| sdk/hanaonazure/arm-hanaonazure/samples/v4-beta/javascript/sapMonitorsUpdateSample.js | Updates generated JS sample for new client API surface. |
| sdk/hanaonazure/arm-hanaonazure/samples/v4-beta/javascript/sapMonitorsListSample.js | Updates generated JS list sample for new client API surface. |
| sdk/hanaonazure/arm-hanaonazure/samples/v4-beta/javascript/sapMonitorsGetSample.js | Updates generated JS get sample for new client API surface. |
| sdk/hanaonazure/arm-hanaonazure/samples/v4-beta/javascript/sapMonitorsDeleteSample.js | Updates generated JS delete sample for new client API surface. |
| sdk/hanaonazure/arm-hanaonazure/samples/v4-beta/javascript/sapMonitorsCreateSample.js | Updates generated JS create sample for new client API surface. |
| sdk/hanaonazure/arm-hanaonazure/samples/v4-beta/javascript/sample.env | Simplifies sample env template. |
| sdk/hanaonazure/arm-hanaonazure/samples/v4-beta/javascript/README.md | Updates JS samples README to new package naming/paths and regenerated descriptions. |
| sdk/hanaonazure/arm-hanaonazure/samples/v4-beta/javascript/providerInstancesListSample.js | Updates generated JS providerInstances list sample. |
| sdk/hanaonazure/arm-hanaonazure/samples/v4-beta/javascript/providerInstancesGetSample.js | Updates generated JS providerInstances get sample. |
| sdk/hanaonazure/arm-hanaonazure/samples/v4-beta/javascript/providerInstancesDeleteSample.js | Updates generated JS providerInstances delete sample. |
| sdk/hanaonazure/arm-hanaonazure/samples/v4-beta/javascript/providerInstancesCreateSample.js | Updates generated JS providerInstances create sample. |
| sdk/hanaonazure/arm-hanaonazure/samples/v4-beta/javascript/package.json | Updates JS samples package dependencies for beta line. |
| sdk/hanaonazure/arm-hanaonazure/samples/v4-beta/javascript/operationsListSample.js | Updates generated JS operations list sample. |
| sdk/hanaonazure/arm-hanaonazure/samples-dev/sapMonitorsUpdateSample.ts | Updates source sample (samples-dev) to match new client API surface. |
| sdk/hanaonazure/arm-hanaonazure/samples-dev/sapMonitorsListSample.ts | Updates source sample (samples-dev) to match new client API surface. |
| sdk/hanaonazure/arm-hanaonazure/samples-dev/sapMonitorsGetSample.ts | Updates source sample (samples-dev) to match new client API surface. |
| sdk/hanaonazure/arm-hanaonazure/samples-dev/sapMonitorsDeleteSample.ts | Updates source sample (samples-dev) to match new client API surface. |
| sdk/hanaonazure/arm-hanaonazure/samples-dev/sapMonitorsCreateSample.ts | Updates source sample (samples-dev) to match new client API surface. |
| sdk/hanaonazure/arm-hanaonazure/samples-dev/providerInstancesListSample.ts | Updates source sample (samples-dev) to match new client API surface. |
| sdk/hanaonazure/arm-hanaonazure/samples-dev/providerInstancesGetSample.ts | Updates source sample (samples-dev) to match new client API surface. |
| sdk/hanaonazure/arm-hanaonazure/samples-dev/providerInstancesDeleteSample.ts | Updates source sample (samples-dev) to match new client API surface. |
| sdk/hanaonazure/arm-hanaonazure/samples-dev/providerInstancesCreateSample.ts | Updates source sample (samples-dev) to match new client API surface. |
| sdk/hanaonazure/arm-hanaonazure/samples-dev/operationsListSample.ts | Updates source sample (samples-dev) to match new client API surface. |
| sdk/hanaonazure/arm-hanaonazure/sample.env | Simplifies root sample env template. |
| sdk/hanaonazure/arm-hanaonazure/README.md | Updates package README links and browser auth snippet ordering/links. |
| sdk/hanaonazure/arm-hanaonazure/package.json | Updates package metadata/deps/scripts for layered API generation. |
| sdk/hanaonazure/arm-hanaonazure/metadata.json | Adds/updates cross-language definition metadata. |
| sdk/hanaonazure/arm-hanaonazure/LICENSE | Formatting-only change (line ending/newline). |
| sdk/hanaonazure/arm-hanaonazure/eslint.config.mjs | Formatting-only adjustments in eslint config. |
| sdk/hanaonazure/arm-hanaonazure/config/tsconfig.test.node.json | Adds path mappings for tests against source. |
| sdk/hanaonazure/arm-hanaonazure/config/tsconfig.test.browser.json | Adds browser test tsconfig with path mappings. |
| sdk/hanaonazure/arm-hanaonazure/config/tsconfig.src.esm.json | Formatting-only include list normalization. |
| sdk/hanaonazure/arm-hanaonazure/config/tsconfig.src.cjs.json | Formatting-only include list normalization. |
| sdk/hanaonazure/arm-hanaonazure/config/tsconfig.src.browser.json | Formatting-only include list normalization. |
| sdk/hanaonazure/arm-hanaonazure/config/tsconfig.samples.json | Formatting-only paths normalization. |
| sdk/hanaonazure/arm-hanaonazure/config/tsconfig.lint.json | Formatting-only include list normalization. |
| sdk/hanaonazure/arm-hanaonazure/CHANGELOG.md | Updates release notes for beta.5 and regeneration/migration messaging. |
| sdk/hanaonazure/arm-hanaonazure/assets.json | Updates assets tag for recordings/resources. |
| sdk/hanaonazure/arm-hanaonazure/api-extractor.json | Formatting-only normalization. |
| sdk/hanaonazure/arm-hanaonazure/_meta.json | Removes legacy AutoRest metadata file. |
| pnpm-lock.yaml | Lockfile updates for dependency graph changes (auto-generated). |
| .github/CODEOWNERS | Updates PR labeling for the hanaonazure area. |
There was a problem hiding this comment.
Found 2 issues: 1 tool issue (API version 2020-02-07-preview is not strictly newer than the version already in use by this package), and 1 design concern (the subscriptionId public class property was removed in the new SDK generation, which is a breaking change for users accessing client.subscriptionId).
📊 Structured Report
{"agent":"mgmt-reviewer","pr":38836,"summary":"issues_found","findings":[{"file":"sdk/hanaonazure/arm-hanaonazure/review/arm-hanaonazure-node.api.md","line":99,"issueType":"tool","category":"api-version","description":"KnownVersions.V20200207Preview = '2020-02-07-preview' is the same as the existing API version already in use by the package, not strictly newer."},{"file":"sdk/hanaonazure/arm-hanaonazure/review/arm-hanaonazure-node.api.md","line":59,"issueType":"design","category":"breaking-change","description":"subscriptionId constructor parameter made optional via new overload and the public class property 'subscriptionId: string' was removed — breaking for users accessing client.subscriptionId."}]}⚡ Benchmarked by Management Release Assistant
Configurations: 'specification/hanaonazure/resource-manager/Microsoft.HanaOnAzure/HanaOnAzure/tspconfig.yaml', API Version: 2020-02-07-preview, SDK Release Type: beta, and CommitSHA: '4375d0c4eb36e73152199e484c0d4537ddd4c9da' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6398432 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.