[DO NOT MERGE] AzureMonitor LiveMetrics onboarding to TypeSpec #42714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 19, 2024 09:47
TimothyMothra
commented
Mar 19, 2024
| /// <summary> Monitoring data point coming from SDK, which includes metrics, documents and other metadata info. </summary> | ||
| internal partial class MonitoringDataPoint | ||
| /// <summary> Monitoring data point coming from the client, which includes metrics, documents and other metadata info. </summary> | ||
| public partial class MonitoringDataPoint |
Author
There was a problem hiding this comment.
this is a bug. this type MUST not be public
TimothyMothra
commented
Mar 19, 2024
| { | ||
| /// <summary> An AND-connected group of FilterInfo objects. </summary> | ||
| internal partial class FilterConjunctionGroupInfo | ||
| public partial class FilterConjunctionGroupInfo |
Author
There was a problem hiding this comment.
this is a bug. this type MUST not be public
3 tasks
added 2 commits
April 1, 2024 15:55
|
Hi @TimothyMothra. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
JimSuplizio
added
the
no-recent-activity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE Opening this PR to discuss how to correctly use TypeSpec api.
Background
We've been using a pre-release version of a swagger to work on the beta of our new SDK.
The new TypeSpec just merged this week Azure/azure-rest-api-specs#27430.
I'm trying to onboard our project to the TypeSpec and found several unexpected changes (shown in this PR).
At this point, I don't know if this is an error with the new Typespec, an error with the .NET generator, or if I've missed an onboarding step.
Steps followed
tsp-location.yamlfile.https://github.com/Azure/azure-sdk-for-net/blob/main/doc/DataPlaneCodeGeneration/AzureSDKCodeGeneration_DataPlane_Quickstart.md
tsp-location.yamlfilehttps://github.com/Azure/azure-sdk-tools/blob/main/doc/common/TypeSpec-Project-Scripts.md#tsp-locationyaml
npm install @azure-tools/typespec-autorest.\sdk\monitor\Azure.Monitor.OpenTelemetry.LiveMetrics\src> dotnet build /t:GenerateCodeChanges
This is a summary of some of the changes I've discovered
internaltopublic.MonitoringDataPointFilterConjunctionGroupInfoDocumentFilterConjunctionGroupInfoDerivedMetricInfoCollectionConfigurationInfoDocumentStreamInfopublicclasses. How to remove these?LiveMetricsClient- we have no need for a "client" class.LiveMetricsClientOptions- we already have our own "options" class.MonitorOpenTelemetryLiveMetricsClientBuilderExtensionsMonitorOpenTelemetryLiveMetricsModelFactoryOpen Questions
https://github.com/Azure/azure-rest-api-specs/blob/main/specification/applicationinsights/ApplicationInsights.LiveMetrics/main.tsp
https://github.com/Azure/azure-rest-api-specs/blob/main/specification/applicationinsights/data-plane/LiveMetrics/preview/2024-04-01-preview/livemetrics.json