Skip to content

feat: Per-Request Language Option for Map Queries #48763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PlaySkyHD
Copy link

@PlaySkyHD PlaySkyHD commented Mar 12, 2025

Changes
Added support for setting the language per request for the following queries:

  • GetPolygon
  • Geocoding
  • ReverseGeocoding

The existing language setting at the MapsSearchClient level remains functional. If no language is provided via request options, the default value from MapsSearchClient is used.

Background
This change was introduced to support a multi-user application, where each user can configure their preferred language. Previously, language settings were only available at the MapsSearchClient level, requiring separate instances per user. With this update, we can specify the language dynamically per request without needing to create multiple client instances.

@PlaySkyHD PlaySkyHD requested a review from dubiety as a code owner March 12, 2025 20:47
@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Maps labels Mar 12, 2025
Copy link

Thank you for your contribution @PlaySkyHD! We will review the pull request and get back to you soon.

@PlaySkyHD
Copy link
Author

@microsoft-github-policy-service agree

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Maps.Search

@PlaySkyHD
Copy link
Author

What does the pipeline step "Verify Generated Code" do? How can I fix it?

Copy link

Hi @PlaySkyHD. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label May 16, 2025
@dubiety
Copy link
Member

dubiety commented May 16, 2025

Hi @PlaySkyHD , thanks for contributing. We're aware of this issue and we'll provide setting language in each API calls in our next release.

@github-actions github-actions bot removed the no-recent-activity There has been no recent activity on this issue. label May 16, 2025
@PlaySkyHD
Copy link
Author

Hey @dubiety,
perfect, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Maps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants