-
Notifications
You must be signed in to change notification settings - Fork 5k
feat: Per-Request Language Option for Map Queries #48763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thank you for your contribution @PlaySkyHD! We will review the pull request and get back to you soon. |
@microsoft-github-policy-service agree |
API change check APIView has identified API level changes in this PR and created following API reviews. |
What does the pipeline step "Verify Generated Code" do? How can I fix it? |
Hi @PlaySkyHD. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
Hi @PlaySkyHD , thanks for contributing. We're aware of this issue and we'll provide setting language in each API calls in our next release. |
Hey @dubiety, |
Changes
Added support for setting the language per request for the following queries:
The existing language setting at the MapsSearchClient level remains functional. If no language is provided via request options, the default value from MapsSearchClient is used.
Background
This change was introduced to support a multi-user application, where each user can configure their preferred language. Previously, language settings were only available at the MapsSearchClient level, requiring separate instances per user. With this update, we can specify the language dynamically per request without needing to create multiple client instances.