Skip to content

Add 2024-08-01-preview to AzureAIInferenceClientOptions #48894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

makazeu
Copy link
Member

@makazeu makazeu commented Mar 17, 2025

Supports 2024-08-01-preview in AzureAIInferenceClientOptions

Should fix the issue dotnet/extensions#6130

Supports 2024-08-01-preview in AzureAIInferenceClientOptions
@github-actions github-actions bot added AI Model Inference AI Projects Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Mar 17, 2025
Copy link

Thank you for your contribution @makazeu! We will review the pull request and get back to you soon.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.AI.Inference

Copy link
Member

@trangevi trangevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is being made to autogenerated code and will just be overwritten at the next generation.

The current way to handle a new api-version is by using a pipeline policy. We have a sample which shows use of a pipeline policy here: https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/ai/Azure.AI.Inference/samples/Sample2_ChatCompletionsWithAoai.md

While it's not showing an api-version modification, it shows the general structure. The api-key handling can be replaced with the following line: message.Request.Uri.Query = $"?api-version={ApiVersion}"; to properly override the query parameter for api-version.

We have a work item to allow passing of api-version to the options object and this behavior will be handled for the user. But in the meantime it must be done manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Model Inference AI Projects Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants